Mirrors/miller
1
0
Fork 0
mirror of https://github.com/johnkerl/miller.git synced 2026-07-27 01:36:10 +00:00
Code Issues Projects Releases Wiki Activity

valgrind findings

Browse source
This commit is contained in:
John Kerl 2015-12-22 20:44:43 -05:00
parent 057183c945
commit f9a5a16820
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
c/cli/argparse.c
View file

@ -52,12 +52,14 @@ void ap_free(ap_state_t* pstate) {
for (sllve_t* pe = pstate->pflag_defs->phead; pe != NULL; pe = pe->pnext) {
ap_flag_def_t* pdef = pe->pvdata;
// xxx temp double-frees w/r/t mappers retaining lists as well ...
// if (pdef->type == AP_STRING_LIST_FLAG && pdef->pval != NULL) {
// slls_t** pplist = pdef->pval;
// if (*pplist != NULL)
// slls_free(*pplist);
// }
// Linked-lists are pointed to by mappers and freed by their free
// methods. If any mappers miss on that contract, we can find out by
// using valgrind --leak-check=full (e.g. reg_test/run --valgrind).
//
//if (pdef->type == AP_STRING_LIST_FLAG && pdef->pval != NULL) {
// slls_t** pplist = pdef->pval;
// slls_free(*pplist);
//}
free(pdef);
}