From e0fe591d25971c7c357bd0d2ea6b4fa224741535 Mon Sep 17 00:00:00 2001 From: John Kerl Date: Sat, 26 Sep 2015 21:55:14 -0400 Subject: [PATCH] standardize CFLAGS usage --- c/Makefile.am | 2 +- c/todo.txt | 2 -- c/unit_test/Makefile.am | 2 +- doc/build.html | 3 ++- doc/content-for-build.html | 1 + 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/c/Makefile.am b/c/Makefile.am index 69c7e3930..8c6f5c61b 100644 --- a/c/Makefile.am +++ b/c/Makefile.am @@ -1,7 +1,7 @@ SUBDIRS= lib cli stream input mapping output containers dsls experimental tools . unit_test reg_test AM_CPPFLAGS= -I${srcdir} -AM_CFLAGS= -Wall -Werror -std=gnu99 -O3 +AM_CFLAGS= -Wall -std=gnu99 bin_PROGRAMS= mlr noinst_PROGRAMS= mlrg \ mlrp diff --git a/c/todo.txt b/c/todo.txt index 6d6c2edc7..d930bcda5 100644 --- a/c/todo.txt +++ b/c/todo.txt @@ -11,8 +11,6 @@ MINOR: * remove -Werror and -O3 from c/Makefile.am; make sure -O2 -g is the default; emphasize @mlrdoc -* mlrg_CFLAGS and mlrp_CFLAGS need ${AM_CFLAGS} at the end or they will just be ignored - * valgrind & UT cline/sline * UTx4xN the format-parsers diff --git a/c/unit_test/Makefile.am b/c/unit_test/Makefile.am index bcbf51bd6..5ba1e560a 100644 --- a/c/unit_test/Makefile.am +++ b/c/unit_test/Makefile.am @@ -12,7 +12,7 @@ check_PROGRAMS = test_mlrutil \ test_join_bucket_keeper AM_CPPFLAGS= -I${srcdir}/.. -AM_CFLAGS= -Wall -Werror -std=gnu99 -O3 +AM_CFLAGS= -Wall -std=gnu99 all_ldadd= \ ../cli/libcli.la \ diff --git a/doc/build.html b/doc/build.html index b43d001c2..ba535698d 100644 --- a/doc/build.html +++ b/doc/build.html @@ -121,7 +121,7 @@ linked). brew update && brew install miller.

You may already have mlr available in your platform’s -package manager on NetBSD, Arch Linux, or perhaps other distributions. +package manager on NetBSD, Debian Linux, Arch Linux, or perhaps other distributions.

Building from source

@@ -144,6 +144,7 @@ package manager on NetBSD, Arch Linux, or perhaps other distributions.
  • ./configure --prefix=$HOME/pkgs
  • ./configure CC=clang
  • ./configure --disable-shared (to make a statically linked executable) +
  • ./configure 'CFLAGS=-Wall -std=gnu99 -O3'
  • etc.
  • make creates the c/mlr executable diff --git a/doc/content-for-build.html b/doc/content-for-build.html index cb23712d8..2daa3a92d 100644 --- a/doc/content-for-build.html +++ b/doc/content-for-build.html @@ -34,6 +34,7 @@ package manager on NetBSD, Debian Linux, Arch Linux, or perhaps other distributi
  • ./configure --prefix=$HOME/pkgs
  • ./configure CC=clang
  • ./configure --disable-shared (to make a statically linked executable) +
  • ./configure 'CFLAGS=-Wall -std=gnu99 -O3'
  • etc.
  • make creates the c/mlr executable