From da2e78299bd2caeb5ba613894988dd6d3f7e7139 Mon Sep 17 00:00:00 2001 From: John Kerl Date: Sat, 10 Sep 2016 20:40:55 -0400 Subject: [PATCH] neaten --- c/mapping/function_manager.h | 1 - c/mapping/mlr_dsl_cst.c | 11 ----------- 2 files changed, 12 deletions(-) diff --git a/c/mapping/function_manager.h b/c/mapping/function_manager.h index ac79fd178..5f5cc746e 100644 --- a/c/mapping/function_manager.h +++ b/c/mapping/function_manager.h @@ -38,7 +38,6 @@ fmgr_t* fmgr_alloc(); void fmgr_free(fmgr_t* pfmgr); -// xxx disallow redefine ? void fmgr_install_udf(fmgr_t* pfmgr, char* name, int arity, udf_defsite_state_t* pdefsitate_state); // Callsites as defined by AST nodes diff --git a/c/mapping/mlr_dsl_cst.c b/c/mapping/mlr_dsl_cst.c index e8d523da4..3ff05ae84 100644 --- a/c/mapping/mlr_dsl_cst.c +++ b/c/mapping/mlr_dsl_cst.c @@ -653,16 +653,6 @@ static mlr_dsl_cst_statement_t* alloc_return_void(mlr_dsl_ast_node_t* pnode, return pstatement; } -// AST: -// -// text="subr_callsite", type=subr_callsite: -// text="s", type=non_sigil_name: -// text="W", type=strnum_literal. -// text="999", type=strnum_literal. - -// xxx need to pass subrstates in here too -//static mlr_dsl_cst_statement_t* alloc_subr_callsite(mlr_dsl_ast_node_t*pnode, lhmsv_t* pcst_subroutine_states, - //fmgr_t* pfmgr, int type_inferencing, int context_flags) static mlr_dsl_cst_statement_t* alloc_subr_callsite(mlr_dsl_ast_node_t* pnode, fmgr_t* pfmgr, lhmsv_t* pcst_subroutine_states, int type_inferencing, int context_flags) { @@ -688,7 +678,6 @@ static mlr_dsl_cst_statement_t* alloc_subr_callsite(mlr_dsl_ast_node_t* pnode, pstatement->subr_callsite_arguments = mlr_malloc_or_die(callsite_arity * sizeof(mv_t)); int i = 0; - // xxx dup check ... for (sllve_t* pe = pname_node->pchildren->phead; pe != NULL; pe = pe->pnext, i++) { mlr_dsl_ast_node_t* pargument_node = pe->pvvalue; pstatement->subr_callsite_argument_evaluators[i] = rval_evaluator_alloc_from_ast(pargument_node,