Mirrors/miller
1
0
Fork 0
mirror of https://github.com/johnkerl/miller.git synced 2026-01-23 02:14:13 +00:00
Code Issues Projects Releases Wiki Activity

error-handling in the CSV-reader's constructor

Browse source
This commit is contained in:
John Kerl 2025-08-15 19:52:37 -04:00
parent 8b524b3ada
commit d2925aafe5
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
pkg/input/record_reader_csv.go
View file

@ -39,6 +39,11 @@ func NewRecordReaderCSV(
if len(readerOptions.IFS) != 1 {
return nil, fmt.Errorf("for CSV, IFS can only be a single character")
}
if readerOptions.CommentHandling != cli.CommentsAreData {
if len(readerOptions.CommentString) != 1 {
return nil, fmt.Errorf("for CSV, the comment prefix must be a single character")
}
}
return &RecordReaderCSV{
readerOptions: readerOptions,
ifs0: readerOptions.IFS[0],
@ -326,7 +331,7 @@ func (reader *RecordReaderCSV) maybeConsumeComment(
// its Write method has pointer receiver. So we have a WorkaroundBuffer
// struct below which has non-pointer receiver.
// Contract with our fork of the go-csv CSV Reader
// Contract with our fork of the go-csv CSV Reader, and, our own constructor.
lib.InternalCodingErrorIf(len(csvRecord) != 1)
recordsAndContexts.PushBack(types.NewOutputString(csvRecord[0], context))