From cdbe8b82efdc7d34491171089d261c3df2359aea Mon Sep 17 00:00:00 2001 From: Stephen Kitt Date: Tue, 23 Aug 2022 20:56:47 +0200 Subject: [PATCH] Account for varying mlr locations (#1086) The expected error output for the "not-a-valid-timezone" test assumes that mlr is invoked as mlr. Use "${MLR}" instead to cope with any invocation path. This also adds a regression test to catch future instances before they get merged. Signed-off-by: Stephen Kitt Signed-off-by: Stephen Kitt --- .github/workflows/go.yml | 5 +++++ .../not-a-valid-timezone/experr | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 09ad6facb..1eb75d0ea 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -28,6 +28,11 @@ jobs: - name: Test run: make check + - name: Regression tests + # We run these with a convoluted path to ensure the tests don't + # rely on a specific invocation + run: test/../mlr regtest -S + - name: PrepareArtifactNonWindows if: matrix.os != 'windows-latest' run: mkdir -p bin/${{matrix.os}} && cp mlr bin/${{matrix.os}} diff --git a/test/cases/dsl-local-date-time-functions/not-a-valid-timezone/experr b/test/cases/dsl-local-date-time-functions/not-a-valid-timezone/experr index c86b0dfb3..fc9d9179d 100644 --- a/test/cases/dsl-local-date-time-functions/not-a-valid-timezone/experr +++ b/test/cases/dsl-local-date-time-functions/not-a-valid-timezone/experr @@ -1 +1 @@ -mlr : unknown time zone this-is-not-a-valid-timezone-name +${MLR} : unknown time zone this-is-not-a-valid-timezone-name