From 9097624d742307b92af06491058b3039437dc643 Mon Sep 17 00:00:00 2001 From: John Kerl Date: Sat, 26 Nov 2022 10:11:27 -0500 Subject: [PATCH] Exclude median from summary default --- internal/pkg/transformers/summary.go | 8 +++++--- test/cases/cli-help/0001/expout | 2 +- test/cases/verb-summary/default/expout | 12 ++++++------ test/cases/verb-summary/transpose/expout | 1 - 4 files changed, 12 insertions(+), 11 deletions(-) diff --git a/internal/pkg/transformers/summary.go b/internal/pkg/transformers/summary.go index ef25c38ef..6b6134c8b 100644 --- a/internal/pkg/transformers/summary.go +++ b/internal/pkg/transformers/summary.go @@ -47,11 +47,11 @@ var allSummarizerInfos = []tSummarizerInfo{ {"minlen", "length of shortest string representation for the field", stAccumulator}, {"maxlen", "length of longest string representation for the field", stAccumulator}, - {"min", "minimum field value", stPercentile}, + {"min", "minimum field value", stAccumulator}, {"p25", "first-quartile field value", stPercentile}, {"median", "median field value", stPercentile}, {"p75", "third-quartile field value", stPercentile}, - {"max", "maximum field value", stPercentile}, + {"max", "maximum field value", stAccumulator}, {"iqr", "interquartile range: p75 - p25", stPercentile}, {"lof", "lower outer fence: p25 - 3.0 * iqr", stPercentile}, {"lif", "lower inner fence: p25 - 1.5 * iqr", stPercentile}, @@ -64,7 +64,6 @@ var summaryDefaultSummarizerNames = []string{ "count", "mean", "min", - "median", "max", "null_count", "distinct_count", @@ -237,6 +236,9 @@ func newFieldSummary() *tFieldSummary { fieldSummary.accumulators["distinct_count"] = utils.NewStats1DistinctCountAccumulator() fieldSummary.accumulators["mode"] = utils.NewStats1ModeAccumulator() + fieldSummary.accumulators["min"] = utils.NewStats1MinAccumulator() + fieldSummary.accumulators["max"] = utils.NewStats1MaxAccumulator() + fieldSummary.accumulators["sum"] = utils.NewStats1SumAccumulator() fieldSummary.accumulators["mean"] = utils.NewStats1MeanAccumulator() fieldSummary.accumulators["stddev"] = utils.NewStats1StddevAccumulator() diff --git a/test/cases/cli-help/0001/expout b/test/cases/cli-help/0001/expout index 153bca52c..e96af8c8c 100644 --- a/test/cases/cli-help/0001/expout +++ b/test/cases/cli-help/0001/expout @@ -1160,7 +1160,7 @@ All summarizers: uof upper outer fence: p75 + 3.0 * iqr Default summarizers: - field_type count mean min median max null_count distinct_count + field_type count mean min max null_count distinct_count Notes: * min, p25, median, p75, and max work for strings as well as numbers diff --git a/test/cases/verb-summary/default/expout b/test/cases/verb-summary/default/expout index 5bceac1ea..20f2a9ba3 100644 --- a/test/cases/verb-summary/default/expout +++ b/test/cases/verb-summary/default/expout @@ -1,6 +1,6 @@ -field_name field_type count null_count distinct_count mean min median max -a string 10 0 5 - eks pan zee -b string 10 0 3 - pan wye zee -i int 10 0 10 5.5000 1 6 10 -x float 10 0 10 0.4536 0.0314 0.5271 0.7587 -y float 10 0 10 0.5945 0.1342 0.7268 0.9762 +field_name field_type count null_count distinct_count mean min max +a string 10 0 5 - eks zee +b string 10 0 3 - pan zee +i int 10 0 10 5.5000 1 10 +x float 10 0 10 0.4536 0.0314 0.7587 +y float 10 0 10 0.5945 0.1342 0.9762 diff --git a/test/cases/verb-summary/transpose/expout b/test/cases/verb-summary/transpose/expout index 19a3606c6..da15e71ea 100644 --- a/test/cases/verb-summary/transpose/expout +++ b/test/cases/verb-summary/transpose/expout @@ -5,5 +5,4 @@ null_count 0 0 0 0 0 distinct_count 5 3 10 10 10 mean - - 5.5000 0.4536 0.5945 min eks pan 1 0.0314 0.1342 -median pan wye 6 0.5271 0.7268 max zee zee 10 0.7587 0.9762