Mirrors/miller
1
0
Fork 0
mirror of https://github.com/johnkerl/miller.git synced 2026-07-17 16:38:54 +00:00
Code Issues Projects Releases Wiki Activity

Multiple style updates (#1974)

Browse source 
* Comment style

* IRecordTransformer -> RecordTransfomer

* make fmt

* else-return style mod

* snake-case -> camel-case

* Remove redundant err = nil and similar zero-value initializations.

* redundant break;

* bugfix

* neaten

* typofix

* simplify/standardize init of zero-length slices

* Standardize fmt.Fprintf w/ errors

* fix double print of "mlr:"

* neatening

* Uniformize error messages

* make docs

* avoid shadowing package names

* shorten some receiver names
This commit is contained in:
John Kerl 2026-02-16 15:49:21 -05:00 • committed by GitHub
parent a3b5d25933
commit 5eb40c9e7b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
307 changed files with 1649 additions and 2555 deletions
Download patch file Download diff file Expand all files Collapse all files

14
pkg/input/record_reader_xtab.go
View file

@ -38,8 +38,8 @@ type tStanza struct {
func newStanza() *tStanza {
return &tStanza{
dataLines: make([]string, 0),
commentLines: make([]string, 0),
dataLines: []string{},
commentLines: []string{},
}
}
@ -157,7 +157,7 @@ func channelizedStanzaScanner(
done = true
break
} else {
fmt.Fprintf(os.Stderr, "mlr: %#v\n", err)
fmt.Fprintf(os.Stderr, "mlr: %v\n", err)
break
}
}
@ -238,7 +238,7 @@ func (reader *RecordReaderXTAB) getRecordBatch(
recordsAndContexts []*types.RecordAndContext,
eof bool,
) {
recordsAndContexts = make([]*types.RecordAndContext, 0)
recordsAndContexts = []*types.RecordAndContext{}
stanzas, more := <-stanzasChannel
if !more {
@ -295,9 +295,8 @@ func (reader *RecordReaderXTAB) recordFromXTABLines(
func newXTABPairSplitter(options *cli.TReaderOptions) iXTABPairSplitter {
if options.IPSRegex == nil {
return &tXTABIPSSplitter{ips: options.IPS, ipslen: len(options.IPS)}
} else {
return &tXTABIPSRegexSplitter{ipsRegex: options.IPSRegex}
}
return &tXTABIPSRegexSplitter{ipsRegex: options.IPSRegex}
}
type tXTABIPSSplitter struct {
@ -371,7 +370,6 @@ func (s *tXTABIPSRegexSplitter) Split(input string) (key, value string, err erro
return kv[0], "", nil
} else if len(kv) == 2 {
return kv[0], kv[1], nil
} else {
return "", "", fmt.Errorf("internal coding error in XTAB reader")
}
return "", "", fmt.Errorf("internal coding error in XTAB reader")
}