Mirrors/miller
1
0
Fork 0
mirror of https://github.com/johnkerl/miller.git synced 2026-07-19 09:24:14 +00:00
Code Issues Projects Releases Wiki Activity

valgrind findings

Browse source
This commit is contained in:
John Kerl 2015-12-24 00:09:32 -05:00
parent 632787eb04
commit 335efd02f5
3 changed files with 3 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

1
c/containers/join_bucket_keeper.c
View file

@ -199,6 +199,7 @@ void join_bucket_keeper_free(join_bucket_keeper_t* pkeeper, char* prepipe) {
sllv_free(pkeeper->pbucket->precords);
free(pkeeper->pbucket);
pkeeper->plrec_reader->pclose_func(pkeeper->plrec_reader->pvstate, pkeeper->pvhandle, prepipe);
pkeeper->plrec_reader->pfree_func(pkeeper->plrec_reader);
lrec_free(pkeeper->prec_peek);
free(pkeeper->pctx);
free(pkeeper);

21
c/mapping/mapper_join.c
View file

@ -292,20 +292,6 @@ static sllv_t* mapper_join_process_sorted(lrec_t* pright_rec, context_t* pctx, v
}
join_bucket_keeper_t* pkeeper = pstate->pjoin_bucket_keeper; // keystroke-saver
// $ cat a
// x=2
// a=3
//
// $ cat b
// a=1
//
// $ mlr join -j a -f a b
// [rightrec] a=1
// mlr: internal coding error: failed transition from prefill state.
// printf("[rightrec] "); // XXX
// lrec_print(pright_rec);
sllv_t* pleft_records = NULL;
sllv_t* pbucket_left_unpaired = NULL;
sllv_t* pout_recs = sllv_alloc();
@ -323,14 +309,9 @@ static sllv_t* mapper_join_process_sorted(lrec_t* pright_rec, context_t* pctx, v
slls_t* pright_field_values = mlr_selected_values_from_record(pright_rec,
pstate->popts->pright_join_field_names);
// printf("[right-field-values] "); // XXX
// slls_print(pright_field_values);
// printf("\n");
if (pright_field_values != NULL) {
// printf("pre-emit\n");
join_bucket_keeper_emit(pkeeper, pright_field_values, &pleft_records, &pbucket_left_unpaired);
// printf("post-emit\n");
slls_free(pright_field_values);
}
if (pstate->popts->emit_left_unpairables) {

1
c/mapping/mapper_stats1.c
View file

@ -923,6 +923,7 @@ static void stats1_percentile_free(stats1_t* pstats1) {
pstate->reference_count--;
if (pstate->reference_count == 0) {
percentile_keeper_free(pstate->ppercentile_keeper);
lhmss_free(pstate->poutput_field_names);
free(pstate);
free(pstats1);
}