Better error message on unparseable TZ environment variable (#1249)

internal/pkg/entrypoint/entrypoint.go

@@ -53,7 +53,7 @@ func Main() MainReturn {
 
 	options, recordTransformers, err := climain.ParseCommandLine(os.Args)
 	if err != nil {
-		fmt.Fprintln(os.Stderr, os.Args[0], ": ", err)
+		fmt.Fprintln(os.Stderr, "mlr:", err)
 		os.Exit(1)
 	}
 

internal/pkg/lib/time.go

@@ -16,9 +16,10 @@ import (
 // platform this is necessary for *changing* TZ mid-process: e.g.  if a DSL
 // statement does 'ENV["TZ"] = Asia/Istanbul'.
 func SetTZFromEnv() error {
-	location, err := time.LoadLocation(os.Getenv("TZ"))
+	tzenv := os.Getenv("TZ")
+	location, err := time.LoadLocation(tzenv)
 	if err != nil {
-		return err
+		return fmt.Errorf("TZ environment variable appears malformed: \"%s\"", tzenv)
 	}
 	time.Local = location
 	return nil

test/cases/dsl-local-date-time-functions/not-a-valid-timezone-2/cmd

@@ -0,0 +1 @@
+mlr --tz .../... -n put -f test/input/sec2localtime-tz.mlr

test/cases/dsl-local-date-time-functions/not-a-valid-timezone-2/experr

@@ -0,0 +1 @@
+mlr: TZ environment variable appears malformed: ".../..."

test/cases/dsl-local-date-time-functions/not-a-valid-timezone/experr

@@ -1 +1 @@
-${MLR} :  unknown time zone this-is-not-a-valid-timezone-name
+mlr: TZ environment variable appears malformed: "this-is-not-a-valid-timezone-name"