Mirrors/miller
1
0
Fork 0
mirror of https://github.com/johnkerl/miller.git synced 2026-01-23 02:14:13 +00:00
Code Issues Projects Releases Wiki Activity

Fix joinv with "" separator (#1794)

Browse source 
* codemod per se

* unit-test coverage
This commit is contained in:
John Kerl 2025-05-01 17:08:55 -04:00 • committed by GitHub
parent 629aebb989
commit 100166532c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pkg/bifs/collections.go
View file

@ -373,7 +373,7 @@ func BIF_joink(input1, input2 *mlrval.Mlrval) *mlrval.Mlrval {
// joinv([3,4,5], ",") -> "3,4,5"
// joinv({"a":3,"b":4,"c":5}, ",") -> "3,4,5"
func BIF_joinv(input1, input2 *mlrval.Mlrval) *mlrval.Mlrval {
if !input2.IsString() {
if !input2.IsStringOrVoid() {
return mlrval.FromNotStringError("joinv", input2)
}
fieldSeparator := input2.AcquireStringValue()