mirror of
https://github.com/alexta69/metube.git
synced 2026-07-17 16:47:30 +00:00
3ea4732c5d
Addresses a full-project review. Backend correctness and availability: - ytdl: cancel() only SIGKILLs the child's process group when the child actually became its own group leader, so a race (or failed setpgrp) can no longer kill the whole server; kill the group on cancel and on shutdown to avoid orphaned ffmpeg children - ytdl: dedicated ThreadPoolExecutor for download supervision so active downloads can't starve extract_info / live probes on the default pool - ytdl/main/subscriptions: route fire-and-forget tasks through a bg_tasks helper that keeps a strong ref and logs failures - subscriptions: run flat-playlist extraction in an executor and check feeds with bounded concurrency so one slow feed can't block the loop; set last_checked on failure so broken feeds aren't retried every 60s - main: validate ids on /start & /delete and numeric env vars at startup; return 400 (not 500) on bad subscriptions/update input; serve /history from memory; move get_custom_dirs off the event loop; restrict t= stripping to YouTube hosts; drop double percent-decode in state guard - dl_formats/ytdl: enforce requested caption format via FFmpegSubtitlesConvertor and strip VTT header metadata only in the pre-cue region so real dialogue is preserved - ytdl: throttle progress events, dedup adds against pending, clear filename/size on error and reject out-of-dir trashcan deletes, pin fork start-method on Linux only Frontend: - retry deletes the done record only after a successful re-add - surface HTTP errors for delete/start and reset the deleting flag - ignore late 'updated' events for rows no longer in the queue - track table rows by map key; FileSizePipe uses base-1024 Also: HTTPS-aware Docker healthcheck, dead-code removal, and shared helpers for path-containment and yt-dlp option merging. Adds/updates unit tests throughout (250 backend tests passing). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
80 lines
3 KiB
Docker
80 lines
3 KiB
Docker
# Pinned to a major version rather than the lts-alpine floating tag: that tag
|
|
# has lagged behind and resolved to a Node patch older than the Angular CLI's
|
|
# minimum supported version, breaking the build. node:22-alpine currently
|
|
# satisfies @angular/cli's >=22.22.3 requirement.
|
|
FROM node:22-alpine AS builder
|
|
|
|
WORKDIR /metube
|
|
COPY ui ./
|
|
RUN corepack enable && corepack prepare pnpm --activate
|
|
RUN CI=true pnpm install && pnpm run build
|
|
|
|
|
|
FROM python:3.13-slim
|
|
|
|
WORKDIR /app
|
|
|
|
COPY pyproject.toml uv.lock docker-entrypoint.sh ./
|
|
|
|
# Use sed to strip carriage-return characters from the entrypoint script (in case building on Windows)
|
|
# Install dependencies
|
|
RUN sed -i 's/\r$//g' docker-entrypoint.sh && \
|
|
chmod +x docker-entrypoint.sh && \
|
|
apt-get update && \
|
|
apt-get install -y --no-install-recommends \
|
|
ca-certificates \
|
|
ffmpeg \
|
|
unzip \
|
|
aria2 \
|
|
coreutils \
|
|
gosu \
|
|
curl \
|
|
tini \
|
|
build-essential && \
|
|
curl -LsSf https://astral.sh/uv/install.sh | UV_INSTALL_DIR=/usr/local/bin sh && \
|
|
UV_PROJECT_ENVIRONMENT=/usr/local uv sync --frozen --no-dev --compile-bytecode && \
|
|
uv cache clean && \
|
|
rm -f /usr/local/bin/uv /usr/local/bin/uvx /usr/local/bin/uvw && \
|
|
curl -fsSL https://deno.land/install.sh | DENO_INSTALL=/usr/local sh -s -- -y && \
|
|
apt-get purge -y --auto-remove build-essential && \
|
|
rm -rf /var/lib/apt/lists/* && \
|
|
mkdir /.cache && chmod 777 /.cache
|
|
|
|
ARG TARGETARCH
|
|
|
|
RUN BGUTIL_TAG="$(curl -Ls -o /dev/null -w '%{url_effective}' https://github.com/jim60105/bgutil-ytdlp-pot-provider-rs/releases/latest | sed 's#.*/tag/##')" && \
|
|
case "$TARGETARCH" in \
|
|
amd64) BGUTIL_ARCH="x86_64" ;; \
|
|
arm64) BGUTIL_ARCH="aarch64" ;; \
|
|
*) echo "Unsupported TARGETARCH: $TARGETARCH" >&2; exit 1 ;; \
|
|
esac && \
|
|
curl -L -o /usr/local/bin/bgutil-pot \
|
|
"https://github.com/jim60105/bgutil-ytdlp-pot-provider-rs/releases/download/${BGUTIL_TAG}/bgutil-pot-linux-${BGUTIL_ARCH}" && \
|
|
chmod +x /usr/local/bin/bgutil-pot && \
|
|
PLUGIN_DIR="$(python3 -c 'import site; print(site.getsitepackages()[0])')" && \
|
|
curl -L -o /tmp/bgutil-ytdlp-pot-provider-rs.zip \
|
|
"https://github.com/jim60105/bgutil-ytdlp-pot-provider-rs/releases/download/${BGUTIL_TAG}/bgutil-ytdlp-pot-provider-rs.zip" && \
|
|
unzip -q /tmp/bgutil-ytdlp-pot-provider-rs.zip -d "${PLUGIN_DIR}" && \
|
|
rm /tmp/bgutil-ytdlp-pot-provider-rs.zip
|
|
|
|
COPY app ./app
|
|
COPY --from=builder /metube/dist/metube ./ui/dist/metube
|
|
|
|
ENV PUID=1000
|
|
ENV PGID=1000
|
|
ENV UMASK=022
|
|
|
|
ENV DOWNLOAD_DIR=/downloads
|
|
ENV STATE_DIR=/downloads/.metube
|
|
ENV TEMP_DIR=/downloads
|
|
ENV PORT=8081
|
|
VOLUME /downloads
|
|
EXPOSE 8081
|
|
HEALTHCHECK --interval=30s --timeout=5s --start-period=20s --retries=3 \
|
|
CMD case "$HTTPS" in true|True|on|1) curl -fsSk "https://localhost:${PORT}/";; *) curl -fsS "http://localhost:${PORT}/";; esac || exit 1
|
|
|
|
# Add build-time argument for version
|
|
ARG VERSION=dev
|
|
ENV METUBE_VERSION=$VERSION
|
|
|
|
ENTRYPOINT ["/usr/bin/tini", "-g", "--", "./docker-entrypoint.sh"]
|