Mirrors/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-07-22 15:37:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

integration: add test for tagged→user-owned conversion panic
Some checks failed
Tests / test (push) Has been cancelled
Details

Browse source 
Add TestTagsAuthKeyConvertToUserViaCLIRegister that reproduces the
exact panic from #3038: register a node with a tags-only PreAuthKey
(no user), force reauth with empty tags, then register via CLI with
a user. The mapper panics on node.Owner().Model().ID when User is nil.

The critical detail is using a tags-only PreAuthKey (User: nil). When
the key is created under a user, the node inherits the User pointer
from createAndSaveNewNode and the bug is masked.

Also add Owner() validity assertions to the existing unit test
TestTaggedNodeWithoutUserToDifferentUser to catch the nil pointer
at the unit test level.

Updates #3038
This commit is contained in:
Kristoffer Dalby 2026-02-02 14:53:27 +00:00
parent 80a34ec3c1
commit ea53078dde
3 changed files with 127 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.github/workflows/test-integration.yaml vendored
View file

@ -247,6 +247,7 @@ jobs:
- TestTagsUserLoginReauthWithEmptyTagsRemovesAllTags
- TestTagsAuthKeyWithoutUserInheritsTags
- TestTagsAuthKeyWithoutUserRejectsAdvertisedTags
- TestTagsAuthKeyConvertToUserViaCLIRegister
uses: ./.github/workflows/integration-test-template.yml
secrets: inherit
with: