Mirrors/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-07-17 16:36:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: scope DestroyUser to only delete target user's pre-auth keys

Browse source 
DestroyUser called ListPreAuthKeys(tx) which returns ALL keys in the
database, then deleted every one of them. This caused deleting any
single user to wipe all pre-auth keys system-wide.

Fix: query only keys belonging to the user being deleted using
tx.Where("user_id = ?", uid).Find(&keys).

Fixes: https://github.com/juanfont/headscale/issues/3154
This commit is contained in:
Jacky 2026-04-05 14:24:01 +09:00
parent 97fa117c48
commit 78926fbde4
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
hscontrol/db/users.go
View file

@ -58,8 +58,8 @@ func DestroyUser(tx *gorm.DB, uid types.UserID) error {
return ErrUserStillHasNodes
}
keys, err := ListPreAuthKeys(tx)
if err != nil {
var keys []types.PreAuthKey
if err := tx.Where("user_id = ?", uid).Find(&keys).Error; err != nil {
return err
}
for _, key := range keys {