Mirrors/filebrowser
1
0
Fork 0
mirror of https://github.com/filebrowser/filebrowser.git synced 2026-01-23 02:35:10 +00:00
Code Issues Projects Releases Wiki Activity

refactor: add more go linters (#970)

Browse source
This commit is contained in:
Oleg Lobanov 2020-06-01 01:12:36 +02:00 • committed by GitHub
parent 54d92a2708
commit 700f32718e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
56 changed files with 436 additions and 221 deletions
Download patch file Download diff file Expand all files Collapse all files

8
users/storage.go
View file

@ -40,7 +40,9 @@ func (s *Storage) Get(baseScope string, id interface{}) (user *User, err error)
if err != nil {
return
}
user.Clean(baseScope)
if err := user.Clean(baseScope); err != nil {
return nil, err
}
return
}
@ -52,7 +54,9 @@ func (s *Storage) Gets(baseScope string) ([]*User, error) {
}
for _, user := range users {
user.Clean(baseScope)
if err := user.Clean(baseScope); err != nil { //nolint:shadow
return nil, err
}
}
return users, err

5
users/users.go
View file

@ -4,11 +4,11 @@ import (
"path/filepath"
"regexp"
"github.com/filebrowser/filebrowser/v2/errors"
"github.com/spf13/afero"
"github.com/filebrowser/filebrowser/v2/errors"
"github.com/filebrowser/filebrowser/v2/files"
"github.com/filebrowser/filebrowser/v2/rules"
"github.com/spf13/afero"
)
// ViewMode describes a view mode.
@ -52,6 +52,7 @@ var checkableFields = []string{
// Clean cleans up a user and verifies if all its fields
// are alright to be saved.
//nolint:gocyclo
func (u *User) Clean(baseScope string, fields ...string) error {
if len(fields) == 0 {
fields = checkableFields