mirror of
https://github.com/ether/etherpad-lite.git
synced 2026-07-19 01:24:19 +00:00
fd975323e0
* Pin plugins to last-known-good versions in backend tests
Pin ep_font_size@0.4.65, ep_headings2@0.2.76, ep_markdown@10.0.1
to the versions that passed on March 31. The newer versions cause
a template crash: Cannot read properties of undefined (reading
'indexOf') at pad.html:67 in toolbar.menu().
This will help narrow down which plugin update is the culprit.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Unpin ep_markdown, 1.0.8 is latest and code-identical to 10.0.1
Only ep_font_size@0.4.65 and ep_headings2@0.2.76 remain pinned to
narrow down which plugin update causes the toolbar template crash.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Use pnpm instead of gnpm for plugin install in backend tests
gnpm ignores version pins — it reports installing the pinned version
but the plugin loader picks up the latest from its store. Switching
to pnpm for the plugin install step so version pins actually work.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Use gnpm exec pnpm for plugin install to bypass gnpm caching
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Remove ep_hash_auth from backend test plugin list
ep_hash_auth blocks unauthenticated requests, causing 28 backend tests
to get 500 Internal Server Error when accessing pads. The tests don't
provide credentials, so any auth plugin will break them.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix ESM/CJS interop for Settings module and harden toolbar
Plugins use require('ep_etherpad-lite/node/utils/Settings') (CJS) but
Settings.ts uses export default (ESM). With tsx, CJS require puts the
default export under .default, so settings.toolbar is undefined and
ep_font_size crashes with "Cannot read properties of undefined
(reading 'indexOf')" when rendering pad.html.
Two fixes:
- Settings.ts: add property getters on module.exports so CJS consumers
can access settings properties directly
- toolbar.ts: guard against undefined buttons array to prevent crashes
if Settings interop doesn't propagate through gnpm's plugin_packages
Tested locally: 735 passing, 0 failing with all plugins.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
270 lines
9.1 KiB
YAML
270 lines
9.1 KiB
YAML
name: "Backend tests"
|
|
|
|
# any branch is useful for testing before a PR is submitted
|
|
on:
|
|
push:
|
|
paths-ignore:
|
|
- "doc/**"
|
|
pull_request:
|
|
paths-ignore:
|
|
- "doc/**"
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
|
|
jobs:
|
|
withoutpluginsLinux:
|
|
env:
|
|
PNPM_HOME: ~/.pnpm-store
|
|
# run on pushes to any branch
|
|
# run on PRs from external forks
|
|
if: |
|
|
(github.event_name != 'pull_request')
|
|
|| (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id)
|
|
name: Linux without plugins
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
node: [">=20.0.0 <21.0.0", ">=22.0.0 <23.0.0", ">=24.0.0 <25.0.0"]
|
|
steps:
|
|
-
|
|
name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Setup gnpm cache
|
|
if: always()
|
|
with:
|
|
path: |
|
|
${{ env.PNPM_HOME }}
|
|
~/.local/share/gnpm
|
|
/usr/local/bin/gnpm
|
|
/usr/local/bin/gnpm-0.0.12
|
|
key: ${{ runner.os }}-gnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-gnpm-store-
|
|
- name: Setup gnpm
|
|
uses: SamTV12345/gnpm-setup@main
|
|
with:
|
|
version: 0.0.12
|
|
-
|
|
name: Install libreoffice
|
|
uses: awalsh128/cache-apt-pkgs-action@v1.6.0
|
|
with:
|
|
packages: libreoffice libreoffice-pdfimport
|
|
version: 1.0
|
|
-
|
|
name: Install all dependencies and symlink for ep_etherpad-lite
|
|
run: gnpm i --frozen-lockfile --runtimeVersion="${{ matrix.node }}"
|
|
- name: Install admin ui
|
|
working-directory: admin
|
|
run: gnpm install --runtimeVersion="${{ matrix.node }}"
|
|
- name: Build admin ui
|
|
working-directory: admin
|
|
run: gnpm build --runtimeVersion="${{ matrix.node }}"
|
|
-
|
|
name: Run the backend tests
|
|
run: gnpm test --runtimeVersion="${{ matrix.node }}"
|
|
- name: Run the new vitest tests
|
|
working-directory: src
|
|
run: gnpm run test:vitest --runtimeVersion="${{ matrix.node }}"
|
|
|
|
withpluginsLinux:
|
|
env:
|
|
PNPM_HOME: ~/.pnpm-store
|
|
# run on pushes to any branch
|
|
# run on PRs from external forks
|
|
if: |
|
|
(github.event_name != 'pull_request')
|
|
|| (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id)
|
|
name: Linux with Plugins
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
node: [">=20.0.0 <21.0.0", ">=22.0.0 <23.0.0", ">=24.0.0 <25.0.0"]
|
|
steps:
|
|
-
|
|
name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Setup pnpm cache
|
|
if: always()
|
|
with:
|
|
path: |
|
|
${{ env.PNPM_HOME }}
|
|
~/.local/share/gnpm
|
|
/usr/local/bin/gnpm
|
|
/usr/local/bin/gnpm-0.0.12
|
|
key: ${{ runner.os }}-gnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-gnpm-store-
|
|
- name: Setup gnpm
|
|
uses: SamTV12345/gnpm-setup@main
|
|
with:
|
|
version: 0.0.12
|
|
-
|
|
name: Install libreoffice
|
|
uses: awalsh128/cache-apt-pkgs-action@v1.6.0
|
|
with:
|
|
packages: libreoffice libreoffice-pdfimport
|
|
version: 1.0
|
|
-
|
|
name: Install all dependencies and symlink for ep_etherpad-lite
|
|
run: gnpm install --frozen-lockfile --runtimeVersion="${{ matrix.node }}"
|
|
- name: Build admin ui
|
|
working-directory: admin
|
|
run: gnpm build --runtimeVersion="${{ matrix.node }}"
|
|
-
|
|
name: Install Etherpad plugins
|
|
run: >
|
|
gnpm install --workspace-root
|
|
ep_align
|
|
ep_author_hover
|
|
ep_cursortrace
|
|
ep_font_size
|
|
ep_headings2
|
|
ep_markdown
|
|
ep_readonly_guest
|
|
ep_set_title_on_pad
|
|
ep_spellcheck
|
|
ep_subscript_and_superscript
|
|
ep_table_of_contents
|
|
-
|
|
name: Run the backend tests
|
|
run: gnpm test --runtimeVersion="${{ matrix.node }}"
|
|
- name: Run the new vitest tests
|
|
working-directory: src
|
|
run: gnpm run test:vitest --runtimeVersion="${{ matrix.node }}"
|
|
|
|
withoutpluginsWindows:
|
|
env:
|
|
PNPM_HOME: ~\\.pnpm-store
|
|
# run on pushes to any branch
|
|
# run on PRs from external forks
|
|
if: |
|
|
(github.event_name != 'pull_request')
|
|
|| (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id)
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
node: [">=20.0.0 <21.0.0", ">=22.0.0 <23.0.0", ">=24.0.0 <25.0.0"]
|
|
name: Windows without plugins
|
|
runs-on: windows-latest
|
|
steps:
|
|
-
|
|
name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Setup pnpm cache
|
|
if: always()
|
|
with:
|
|
path: |
|
|
${{ env.PNPM_HOME }}
|
|
C:\gnpm\
|
|
C:\Users\runneradmin\AppData\Roaming\gnpm\
|
|
key: ${{ runner.os }}-gnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-gnpm-store-
|
|
- name: Setup gnpm
|
|
uses: SamTV12345/gnpm-setup@main
|
|
with:
|
|
version: 0.0.12
|
|
-
|
|
name: Install all dependencies and symlink for ep_etherpad-lite
|
|
run: gnpm install --frozen-lockfile --runtimeVersion="${{ matrix.node }}"
|
|
- name: Build admin ui
|
|
working-directory: admin
|
|
run: gnpm build --runtimeVersion="${{ matrix.node }}"
|
|
-
|
|
name: Fix up the settings.json
|
|
run: |
|
|
powershell -Command "(gc settings.json.template) -replace '\"max\": 10', '\"max\": 10000' | Out-File -encoding ASCII settings.json.holder"
|
|
powershell -Command "(gc settings.json.holder) -replace '\"points\": 10', '\"points\": 1000' | Out-File -encoding ASCII settings.json"
|
|
-
|
|
name: Run the backend tests
|
|
working-directory: src
|
|
run: gnpm test --runtimeVersion="${{ matrix.node }}"
|
|
- name: Run the new vitest tests
|
|
working-directory: src
|
|
run: gnpm run test:vitest --runtimeVersion="${{ matrix.node }}"
|
|
|
|
withpluginsWindows:
|
|
env:
|
|
PNPM_HOME: ~\\.pnpm-store
|
|
# run on pushes to any branch
|
|
# run on PRs from external forks
|
|
if: |
|
|
(github.event_name != 'pull_request')
|
|
|| (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id)
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
node: [">=20.0.0 <21.0.0", ">=22.0.0 <23.0.0", ">=24.0.0 <25.0.0"]
|
|
name: Windows with Plugins
|
|
runs-on: windows-latest
|
|
|
|
steps:
|
|
-
|
|
name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Setup pnpm cache
|
|
if: always()
|
|
with:
|
|
path: |
|
|
${{ env.PNPM_HOME }}
|
|
C:\gnpm\
|
|
C:\Users\runneradmin\AppData\Roaming\gnpm\
|
|
key: ${{ runner.os }}-gnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-gnpm-store-
|
|
- name: Setup gnpm
|
|
uses: SamTV12345/gnpm-setup@main
|
|
with:
|
|
version: 0.0.12
|
|
- name: Install dependencies
|
|
run: gnpm install --runtimeVersion="${{ matrix.node }}"
|
|
- name: Build admin ui
|
|
working-directory: admin
|
|
run: gnpm build --runtimeVersion="${{ matrix.node }}"
|
|
-
|
|
name: Install Etherpad plugins
|
|
run: >
|
|
gnpm install --workspace-root
|
|
ep_align
|
|
ep_author_hover
|
|
ep_cursortrace
|
|
ep_font_size
|
|
ep_headings2
|
|
ep_markdown
|
|
ep_readonly_guest
|
|
ep_set_title_on_pad
|
|
ep_spellcheck
|
|
ep_subscript_and_superscript
|
|
ep_table_of_contents
|
|
# Etherpad core dependencies must be installed after installing the
|
|
# plugin's dependencies, otherwise npm will try to hoist common
|
|
# dependencies by removing them from src/node_modules and installing them
|
|
# in the top-level node_modules. As of v6.14.10, npm's hoist logic appears
|
|
# to be buggy, because it sometimes removes dependencies from
|
|
# src/node_modules but fails to add them to the top-level node_modules.
|
|
# Even if npm correctly hoists the dependencies, the hoisting seems to
|
|
# confuse tools such as `npm outdated`, `npm update`, and some ESLint
|
|
# rules.
|
|
-
|
|
name: Install all dependencies and symlink for ep_etherpad-lite
|
|
run: gnpm install --frozen-lockfile --runtimeVersion="${{ matrix.node }}"
|
|
-
|
|
name: Fix up the settings.json
|
|
run: |
|
|
powershell -Command "(gc settings.json.template) -replace '\"max\": 10', '\"max\": 10000' | Out-File -encoding ASCII settings.json.holder"
|
|
powershell -Command "(gc settings.json.holder) -replace '\"points\": 10', '\"points\": 1000' | Out-File -encoding ASCII settings.json"
|
|
-
|
|
name: Run the backend tests
|
|
working-directory: src
|
|
run: gnpm test --runtimeVersion="${{ matrix.node }}"
|
|
- name: Run the new vitest tests
|
|
working-directory: src
|
|
run: gnpm run test:vitest --runtimeVersion="${{ matrix.node }}"
|