Mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2026-07-19 09:34:07 +00:00
Code Issues Projects Releases Wiki Activity
etherpad-lite/src/node/utils
History
John McLear ce83181ac3
Lgtm bugfixes (#4838) 
* code tidy up: always evaluates

* tidy up: is always true

* tidy up: remove unused code

* always true/false variables

* unused variable

* tidy up: remove unused code in caretPosition.js

* for squash: Revert "tidy up: remove unused code in caretPosition.js"

The `if` condition was previously always true, so the body should be
preserved. If the body is preserved, other logic can be deleted. I
opened PR #4845 to clean it all up.

This reverts commit 75b03e5a7d.

* for squash: simplify

* for squash: Explain that the getter is used for its side effects

It's very weird to call a getter without using its return value. Add a
comment explaining why this is done so that the reader doesn't get
confused.

* for squash: Revert "tidy up: remove unused code"

The exception test was the purpose of the code.

This reverts commit 85153b1676.

* for squash: Log the tsort results

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-02-22 08:26:35 +00:00
..
Abiword.js lint: src/node/utils/Abiword.js 2021-01-25 22:53:11 -05:00
AbsolutePaths.js lint: AbsolutePaths.js 2021-02-21 21:09:02 -05:00
caching_middleware.js Remove unnecessary path.normalize() calls 2021-02-18 19:18:59 +00:00
Cli.js lint: src/node/utils/Cli.js 2021-01-25 22:53:11 -05:00
customError.js lint: src/node/utils/customError.js 2021-01-25 22:53:11 -05:00
ExportEtherpad.js lint: src/node/utils/ExportEtherpad.js 2021-01-25 22:53:11 -05:00
ExportHelper.js lint: src/node/utils/ExportHelper.js 2021-01-25 22:53:11 -05:00
ExportHtml.js Lgtm bugfixes (#4838) 2021-02-22 08:26:35 +00:00
ExportTxt.js lint: ExportTxt.js 2021-02-21 21:09:02 -05:00
ImportEtherpad.js lint: ImportEtherpad.js 2021-02-21 21:09:02 -05:00
ImportHtml.js lint: src/node/utils/ImportHtml.js 2021-01-25 22:53:11 -05:00
LibreOffice.js lint: src/node/utils/LibreOffice.js 2021-01-25 22:53:11 -05:00
Minify.js Use settings.root to anchor pathnames 2021-02-18 19:18:59 +00:00
MinifyWorker.js lint: src/node/utils/MinifyWorker.js 2021-01-25 22:53:11 -05:00
NodeVersion.js lint: NodeVersion.js 2021-02-21 21:09:02 -05:00
padDiff.js lint: src/node/utils/padDiff.js 2021-01-25 22:53:11 -05:00
path_exists.js lint: src/node/utils/path_exists.js 2021-01-25 22:53:11 -05:00
promises.js lint: src/node/utils/promises.js 2021-01-25 22:53:11 -05:00
randomstring.js lint: src/node/utils/randomstring.js 2021-01-25 22:53:11 -05:00
run_cmd.js run_cmd: Enhance with ability to return stdout as string 2021-02-18 19:18:59 +00:00
Settings.js lint: Settings.js 2021-02-21 21:09:02 -05:00
tar.json Move vendor libraries to /vendors folder and exclude from LGTM 2021-02-21 15:07:39 +00:00
TidyHtml.js lint: src/node/utils/TidyHtml.js 2021-01-25 22:53:11 -05:00
toolbar.js fix: runtime error if no buttons are present in toolbar (#4680) 2021-01-26 11:02:54 +00:00
UpdateCheck.js lint: src/node/utils/UpdateCheck.js 2021-01-25 22:53:11 -05:00