mirror of
https://github.com/ether/etherpad-lite.git
synced 2026-07-18 00:57:55 +00:00
958590d1c8
* chore(docker): clear most CVEs in published image — npm/pnpm/uuid + drop curl Cuts published-image vulnerabilities from 18 (4H/13M/1L) across 8 packages to 12 (2H/9M/1L) across 3 packages. The remaining three (curl/libcurl, git, busybox) are all upstream Alpine 3.23 packages with "not fixed" status — libcurl is pulled in transitively by git and cannot be removed independently. Changes: - Provision pnpm via corepack instead of `npm install -g pnpm`, then remove the bundled npm. The base image's npm@10.9.7 ships old transitives (picomatch 4.0.3 → CVE-2026-33671/33672, brace-expansion 2.0.2 → CVE-2026-33750) that we don't otherwise need at runtime; corepack handles pnpm directly without npm. Fixes 1H + 1M. - Bump PnpmVersion 10.28.2 → 10.33.2 to align with the rest of the workflow and pull in pnpm's patched bundled brace-expansion (5.0.5 vs 5.0.4). Fixes 1M. - Add `uuid@<14.0.0` → `>=14.0.0` to pnpm.overrides (GHSA-w5hq-g745-h8pq). Fixes 1M. - Drop `curl` from the runtime apk add list and switch HEALTHCHECK to wget (busybox built-in). curl was only invoked by the healthcheck and by dev/CI scripts that don't run in the container. Removes the curl CLI binary; libcurl remains as a git transitive dep, so the `apk/alpine/curl` advisories scout reports against libcurl persist but aren't reachable from any code we ship. As a side-effect this also clears nghttp2 (CVE-2026-27135) which was a curl-CLI dep. - Switch HEALTHCHECK URL from `localhost` to `127.0.0.1` — alpine/musl resolves localhost to ::1 first and Etherpad only binds IPv4. Verified locally: docker build → docker run → healthy → docker scout cves shows 12 CVEs / 3 packages. * fix(docker): refresh corepack before preparing pnpm (Qodo) Node 22's bundled corepack ships a stale signing-key list and can reject newer pnpm releases (nodejs/corepack#612), which would fail the image build at `corepack prepare`. Mirror the snap/snapcraft.yaml workaround: `npm install -g corepack@latest` before activating pnpm, in both adminbuild and build stages. npm is still removed afterwards. * docs(changelog): note docker image dropping curl/npm/npx (Qodo) Address Qodo's "backwards-incompatible change without mitigation" rule violations by documenting the removal in the 2.7.3 breaking-changes section. Operators who exec into the container can apk add curl on demand or use the busybox wget / pnpm already present. * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm --------- Co-authored-by: SamTV12345 <40429738+samtv12345@users.noreply.github.com>
97 lines
3.2 KiB
YAML
97 lines
3.2 KiB
YAML
# Workflow for building and deploying the VitePress site to GitHub Pages.
|
|
# Build runs on every push to develop and on every PR that touches docs (so
|
|
# a build regression is caught at review time instead of breaking develop
|
|
# after merge — see #7640). Deploy runs only on push: the github-pages
|
|
# environment has protection rules that reject PR refs, and a PR build
|
|
# never produced an artifact to deploy anyway.
|
|
name: Deploy Docs to GitHub Pages
|
|
|
|
on:
|
|
push:
|
|
branches: ["develop"]
|
|
paths:
|
|
- doc/**
|
|
- .github/workflows/build-and-deploy-docs.yml
|
|
pull_request:
|
|
paths:
|
|
- doc/**
|
|
- .github/workflows/build-and-deploy-docs.yml
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
pages: write
|
|
id-token: write
|
|
packages: read
|
|
|
|
# Allow only one concurrent deployment, skipping runs queued between the run
|
|
# in-progress and latest queued. Do NOT cancel in-progress runs — production
|
|
# deployments are allowed to complete.
|
|
concurrency:
|
|
group: "pages"
|
|
cancel-in-progress: false
|
|
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Cache pnpm store
|
|
with:
|
|
path: ~/.pnpm-store
|
|
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-pnpm-store-
|
|
- uses: actions/cache@v5
|
|
name: Cache vitepress build
|
|
with:
|
|
path: doc/.vitepress/cache
|
|
key: ${{ runner.os }}-vitepress-${{ hashFiles('doc/**/*.md', 'doc/.vitepress/config.*') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-vitepress-
|
|
- uses: pnpm/action-setup@v6
|
|
name: Install pnpm
|
|
with:
|
|
run_install: false
|
|
# Pin Node so the build does not silently fall back to whatever the
|
|
# runner image ships with. vite 8 requires Node ^20.19.0 || >=22.12.0;
|
|
# the repo declares engines.node >=22.12.0 to match.
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: 22
|
|
cache: pnpm
|
|
- name: Setup Pages
|
|
if: github.event_name == 'push'
|
|
uses: actions/configure-pages@v6
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
- name: Build app
|
|
working-directory: doc
|
|
run: pnpm run docs:build
|
|
env:
|
|
GITHUB_PAGES: ${{ github.event_name == 'push' && 'true' || '' }}
|
|
COMMIT_REF: ${{ github.sha }}
|
|
- name: Upload artifact
|
|
if: github.event_name == 'push'
|
|
uses: actions/upload-pages-artifact@v5
|
|
with:
|
|
path: './doc/.vitepress/dist'
|
|
|
|
# Deploy to GitHub Pages on push to develop only. Kept as a separate job
|
|
# because the github-pages environment's protection rules reject any
|
|
# non-develop ref (including PR merge refs), which used to fail the entire
|
|
# workflow at job-creation time before any build step could run.
|
|
deploy:
|
|
needs: build
|
|
if: github.event_name == 'push'
|
|
environment:
|
|
name: github-pages
|
|
url: ${{ steps.deployment.outputs.page_url }}
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Deploy to GitHub Pages
|
|
id: deployment
|
|
uses: actions/deploy-pages@v5
|