mirror of
https://github.com/ether/etherpad-lite.git
synced 2026-07-18 09:04:54 +00:00
ef0b257d3e
* fix: RTL URL parameter rtl=false now correctly disables RTL mode The rtl parameter callback only handled rtl=true (checkVal was 'true'), so rtl=false was ignored and the layout stayed in RTL from the cookie. Now accepts any value and sets rtlIsTrue = (val === 'true'). Also always applies the RTL setting instead of only when true, so switching from rtl=true to rtl=false takes effect. Fixes #5559 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: only override RTL when explicitly set via URL/server config The unconditional changeViewOption('rtlIsTrue', false) overwrote cookie-persisted RTL preferences and language-direction defaults. Track explicit setting with rtlIsExplicit flag so we only override when the user or server actually specified an rtl value. Adds regression tests for rtl=true, rtl=false, and cookie persistence. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: move RTL override into postAceInit to fix race condition The RTL changeViewOption call was racing with padeditor.init() — the async setViewOptions(initialViewOptions) at the end of init overwrote the URL-param-based RTL setting. Moving it into postAceInit ensures padeditor is fully initialized. Also switched tests to use Playwright auto-retrying assertions for robustness. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve Playwright test failures for RTL URL parameter Three issues fixed: - setCheckbox used .attr('checked') instead of .prop('checked'), so the JS checked property was never set and Playwright saw unchecked state - html10n localized event overwrote RTL setting from URL params and cookie preferences; now skips override when either is active - Server default padOptions.rtl:false was treated as explicit, overwriting cookie-persisted RTL; added fromUrl flag to distinguish URL from server All 94 Playwright tests and 740 backend tests pass locally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| css | ||
| font | ||
| img | ||
| js | ||
| skins | ||
| empty.html | ||
| favicon.ico | ||
| robots.txt | ||
| tests.html | ||