mirror of
https://github.com/ether/etherpad-lite.git
synced 2026-07-24 18:47:16 +00:00
b19ad89eb0
* fix(docker): don't let pnpm self-provision a pinned version on offline boot (#7911) The official Docker image installs pnpm directly via npm (corepack was dropped for Node 25+). Standalone pnpm still honours the "packageManager" pin in package.json: the image's pnpm intentionally lags that pin (pnpm 11.1.x enforces a minimum-release-age policy the frozen-lockfile build can't satisfy), so pnpm treats every invocation — including the informational `pnpm --version` probe Etherpad runs at startup — as a request to download and run the pinned build. Behind a corporate firewall / in an air-gapped install that download fails: [WARN] plugins - Failed to get pnpm version: Error: Command exited with code 1: pnpm --version which is what #7911 reported. Fix — neutralise the gap instead of closing it (closing it would break the frozen-lockfile build on 11.1.x): - Dockerfile build stage sets `pnpm_config_pm_on_fail=ignore` (the pnpm 11 successor to managePackageManagerVersions), inherited by the development and production runtime stages. pnpm then uses the installed pnpm instead of fetching the pinned one. It does not change which pnpm runs the build-time install, so the frozen-lockfile build is unaffected. - plugins.ts startup probe and the updater's pnpm-on-PATH checks run with the same flag, so the fix also covers non-Docker offline installs and the probe can never fail-loud. Add a backend spec that fails CI if the offline guard is dropped while the image pnpm differs from the package.json pin. Verified with a standalone (non-corepack) pnpm: a "packageManager" mismatch makes `pnpm --version` exit 1 by default (tries to fetch the pinned build), and exit 0 reading the local version with pm_on_fail=ignore. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test: scope pnpm offline-guard check to the runtime-inherited build stage Address Qodo review: the regression spec matched ENV pnpm_config_pm_on_fail anywhere in the Dockerfile, so it would still pass if the guard were removed from the `build` stage (which the runtime stages inherit) but left in the throwaway `adminbuild` stage — reintroducing the offline failure. Extract the `build` stage block and assert the ENV is present there specifically. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| admin | ||
| api | ||
| fixtures | ||
| anonymizeAuthor.ts | ||
| anonymizeIp.ts | ||
| apicalls.ts | ||
| authorTokenCookie.ts | ||
| chat.ts | ||
| clientvar_rev_consistency.ts | ||
| colorutils.ts | ||
| compactPad.ts | ||
| contentcollector.ts | ||
| crypto.ts | ||
| dockerfilePnpmPin.ts | ||
| ensureAuthorTokenCookie.ts | ||
| export.ts | ||
| export_list.ts | ||
| ExportEtherpad.ts | ||
| favicon-test-custom.png | ||
| favicon-test-skin.png | ||
| favicon.ts | ||
| filterUpdatablePluginNames.ts | ||
| health.ts | ||
| hooks.ts | ||
| i18n.ts | ||
| import.ts | ||
| ImportEtherpad.ts | ||
| ipLoggingSetting.ts | ||
| largePaste.ts | ||
| LinkInstaller.ts | ||
| lowerCasePadIds.ts | ||
| messages.ts | ||
| npmpublish-workflow.ts | ||
| OIDCAdapter.ts | ||
| openapi-admin.ts | ||
| Pad.ts | ||
| padDeletionManager.ts | ||
| padInsertAuthorInvariant.ts | ||
| padOptionsLegacyDefaults.ts | ||
| pads-with-spaces.ts | ||
| proxyPathRedirect.ts | ||
| pwaManifest.ts | ||
| regression-db.ts | ||
| run_cmd.ts | ||
| sanitizePluginsForWire.ts | ||
| SecretRotator.ts | ||
| sessionIdCookie.ts | ||
| SessionStore.ts | ||
| settings.json | ||
| settings.ts | ||
| settingsModalHeading.ts | ||
| setup-trusted-publishers.ts | ||
| socialMeta-unit.ts | ||
| socialMeta.ts | ||
| socketio.ts | ||
| specialpages.ts | ||
| Stream.ts | ||
| timesliderRedirect.ts | ||
| tokenTransfer.ts | ||
| undo_clear_authorship.ts | ||
| updateActions.ts | ||
| updater-integration.ts | ||
| updater-scheduler-integration.ts | ||
| updater-window-integration.ts | ||
| updateStatus.ts | ||
| urlBasePath.ts | ||
| webaccess.ts | ||
