mirror of
https://github.com/ether/etherpad-lite.git
synced 2026-07-17 16:47:05 +00:00
* Roll Node.js floor back to >= 24 (Active LTS) Closes #7779. #7779 originally proposed bumping past the Node 25 stop-gap to Node 26. After re-checking the release schedule, the cleaner LTS target is actually Node 24: - Node 24 (Krypton) is currently in Active LTS, supported until ~May 2028. - Node 25 hit end-of-life on April 10 2026 — the floor merged in #7752 / #7749 / #7754 a day ago ships an already-EOL major. - Node 26 was released May 5 2026 and does not enter Active LTS until October 2026. So this PR reverts the Node 25 ratchet from those three PRs and lands on Node 24 — Etherpad's runtime floor stays on a supported LTS for the next ~2 years. Runtime / infra - `package.json` + `src/package.json`: `engines.node` `>=25.0.0` -> `>=24.0.0` - `bin/functions.sh`, `bin/installer.sh`, `bin/installer.ps1`: `REQUIRED_NODE_MAJOR` 25 -> 24 - `Dockerfile`: `node:25-alpine` -> `node:24-alpine` (both stages). Corepack-via-npm workaround is intentionally kept: it works on Node 24 (which still ships corepack) and on Node 25+ (which doesn't), so the same recipe survives the next LTS bump without churn. Comments reworded accordingly. - `snap/snapcraft.yaml`: pinned `NODE_VERSION` 25.9.0 -> 24.15.0; design notes + corepack comment adjusted - `packaging/nfpm.yaml`: `nodejs (>= 25)` -> `nodejs (>= 24)` in top-level depends + deb/rpm overrides - `packaging/bin/etherpad`: comment matches the new pin - `packaging/README.md`: build prereqs + apt install snippet point at `node_24.x`; the long-stale "engines.node floor is 20" line is fixed while we're here - `.github/workflows/*.yml`: setup-node `node-version` 25 -> 24 across every workflow; backend / frontend-admin / upgrade matrices `[25]` -> `[24]` - `.github/workflows/deb-package.yml`: `NODE_MAJOR=25` + `node_25.x` smoke-test installer -> 24 - `bin/plugins/lib/npmpublish.yml`: 25 -> 24 (template propagates to the ~80 ether/* plugins via update-plugins workflow) Docs - `README.md`: install one-liner + Requirements -> Node.js >= 24 - `doc/npm-trusted-publishing.md`: runner requirement -> Node 24 - `doc/plugins.md` / `doc/plugins.adoc`: plugin metadata example `engines.node` -> `">=24.0.0"` @types/node is left at ^25.8.0 — newer type definitions cover Node 24 runtime fine and avoid an unnecessary lockfile churn. Companion homepage one-liner change to follow on ether/ether.github.com. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(plugins): example engines.node = ">=22.0.0", not core's floor Plugin code is overwhelmingly ace-hook glue and rarely uses Node-version- specific APIs, so plugin engines.node should reflect the plugin's own requirements, not track core. Showing core's 24-floor in the example encouraged plugin authors to blindly copy a tighter pin than necessary and locked plugins out of being installable on older Etherpad/Node deployments. Use the most-recent Node LTS that has actually reached EOL (20 -> EOL April 2026) as the example floor, i.e. >=22. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
115 lines
4.1 KiB
YAML
115 lines
4.1 KiB
YAML
name: Update Plugins
|
|
|
|
on:
|
|
schedule:
|
|
- cron: '0 6 * * *' # Daily at 06:00 UTC
|
|
workflow_dispatch: # Allow manual trigger
|
|
|
|
# The cross-repo work (cloning ether/ep_* repos, pushing updates, merging
|
|
# Dependabot PRs) is authenticated via secrets.PLUGINS_PAT. The default
|
|
# GITHUB_TOKEN only needs read access to this repo for actions/checkout.
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
update-plugins:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Check out etherpad-lite
|
|
uses: actions/checkout@v6
|
|
|
|
- uses: pnpm/action-setup@v6
|
|
name: Install pnpm
|
|
with:
|
|
run_install: false
|
|
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: 24
|
|
|
|
- name: Install bin dependencies
|
|
working-directory: ./bin
|
|
run: pnpm install
|
|
|
|
- name: Configure git
|
|
run: |
|
|
git config --global user.name 'github-actions[bot]'
|
|
git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com'
|
|
|
|
- name: Clone and update all plugins
|
|
env:
|
|
GH_TOKEN: ${{ secrets.PLUGINS_PAT }}
|
|
run: |
|
|
# Configure git to use the PAT for all ether/ repos
|
|
git config --global url."https://x-access-token:${GH_TOKEN}@github.com/ether/".insteadOf "https://github.com/ether/"
|
|
|
|
cd ..
|
|
# List all ep_* repos from ether org
|
|
plugins=$(gh repo list ether --limit 200 --json name --jq '.[] | select(.name | startswith("ep_")) | .name')
|
|
|
|
failed=""
|
|
succeeded=""
|
|
skipped=""
|
|
|
|
for plugin in $plugins; do
|
|
echo "============================================================"
|
|
echo "Processing $plugin"
|
|
echo "============================================================"
|
|
|
|
# Clone if not present
|
|
if [ ! -d "$plugin" ]; then
|
|
git clone "https://github.com/ether/${plugin}.git" "$plugin" || { echo "SKIP: clone failed"; skipped="$skipped $plugin"; continue; }
|
|
fi
|
|
|
|
# Pull latest
|
|
(cd "$plugin" && git pull --ff-only) || { echo "SKIP: pull failed"; skipped="$skipped $plugin"; continue; }
|
|
|
|
# Run checkPlugin with autopush — continue on failure
|
|
if cd etherpad-lite/bin && pnpm run checkPlugin "$plugin" autopush 2>&1; then
|
|
succeeded="$succeeded $plugin"
|
|
else
|
|
echo "WARN: checkPlugin failed for $plugin"
|
|
failed="$failed $plugin"
|
|
fi
|
|
cd ../..
|
|
done
|
|
|
|
echo ""
|
|
echo "============================================================"
|
|
echo "SUMMARY"
|
|
echo "============================================================"
|
|
echo "Succeeded:$(echo $succeeded | wc -w) -$succeeded"
|
|
echo "Failed:$(echo $failed | wc -w) -$failed"
|
|
echo "Skipped:$(echo $skipped | wc -w) -$skipped"
|
|
|
|
- name: Merge clean Dependabot PRs on plugin repos
|
|
env:
|
|
GH_TOKEN: ${{ secrets.PLUGINS_PAT }}
|
|
run: |
|
|
# For every ep_* repo under ether, merge any Dependabot PR whose
|
|
# mergeStateStatus is CLEAN (no conflicts, branch up to date, all
|
|
# required checks green). Anything else is left alone for a human.
|
|
plugins=$(gh repo list ether --limit 200 --json name --jq '.[] | select(.name | startswith("ep_")) | .name')
|
|
|
|
merged=""
|
|
for plugin in $plugins; do
|
|
repo="ether/${plugin}"
|
|
prs=$(gh pr list --repo "$repo" \
|
|
--author "app/dependabot" \
|
|
--state open \
|
|
--json number,mergeStateStatus,title \
|
|
--jq '.[] | select(.mergeStateStatus=="CLEAN") | .number') || continue
|
|
|
|
for pr in $prs; do
|
|
echo "Merging ${repo}#${pr}"
|
|
if gh pr merge --repo "$repo" --squash --delete-branch "$pr"; then
|
|
merged="$merged ${repo}#${pr}"
|
|
else
|
|
echo "WARN: failed to merge ${repo}#${pr}"
|
|
fi
|
|
done
|
|
done
|
|
|
|
echo ""
|
|
echo "Merged Dependabot PRs:$merged"
|