mirror of
https://github.com/ether/etherpad-lite.git
synced 2026-07-17 16:47:05 +00:00
* Roll Node.js floor back to >= 24 (Active LTS) Closes #7779. #7779 originally proposed bumping past the Node 25 stop-gap to Node 26. After re-checking the release schedule, the cleaner LTS target is actually Node 24: - Node 24 (Krypton) is currently in Active LTS, supported until ~May 2028. - Node 25 hit end-of-life on April 10 2026 — the floor merged in #7752 / #7749 / #7754 a day ago ships an already-EOL major. - Node 26 was released May 5 2026 and does not enter Active LTS until October 2026. So this PR reverts the Node 25 ratchet from those three PRs and lands on Node 24 — Etherpad's runtime floor stays on a supported LTS for the next ~2 years. Runtime / infra - `package.json` + `src/package.json`: `engines.node` `>=25.0.0` -> `>=24.0.0` - `bin/functions.sh`, `bin/installer.sh`, `bin/installer.ps1`: `REQUIRED_NODE_MAJOR` 25 -> 24 - `Dockerfile`: `node:25-alpine` -> `node:24-alpine` (both stages). Corepack-via-npm workaround is intentionally kept: it works on Node 24 (which still ships corepack) and on Node 25+ (which doesn't), so the same recipe survives the next LTS bump without churn. Comments reworded accordingly. - `snap/snapcraft.yaml`: pinned `NODE_VERSION` 25.9.0 -> 24.15.0; design notes + corepack comment adjusted - `packaging/nfpm.yaml`: `nodejs (>= 25)` -> `nodejs (>= 24)` in top-level depends + deb/rpm overrides - `packaging/bin/etherpad`: comment matches the new pin - `packaging/README.md`: build prereqs + apt install snippet point at `node_24.x`; the long-stale "engines.node floor is 20" line is fixed while we're here - `.github/workflows/*.yml`: setup-node `node-version` 25 -> 24 across every workflow; backend / frontend-admin / upgrade matrices `[25]` -> `[24]` - `.github/workflows/deb-package.yml`: `NODE_MAJOR=25` + `node_25.x` smoke-test installer -> 24 - `bin/plugins/lib/npmpublish.yml`: 25 -> 24 (template propagates to the ~80 ether/* plugins via update-plugins workflow) Docs - `README.md`: install one-liner + Requirements -> Node.js >= 24 - `doc/npm-trusted-publishing.md`: runner requirement -> Node 24 - `doc/plugins.md` / `doc/plugins.adoc`: plugin metadata example `engines.node` -> `">=24.0.0"` @types/node is left at ^25.8.0 — newer type definitions cover Node 24 runtime fine and avoid an unnecessary lockfile churn. Companion homepage one-liner change to follow on ether/ether.github.com. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(plugins): example engines.node = ">=22.0.0", not core's floor Plugin code is overwhelmingly ace-hook glue and rarely uses Node-version- specific APIs, so plugin engines.node should reflect the plugin's own requirements, not track core. Showing core's 24-floor in the example encouraged plugin authors to blindly copy a tighter pin than necessary and locked plugins out of being installable on older Etherpad/Node deployments. Use the most-recent Node LTS that has actually reached EOL (20 -> EOL April 2026) as the example floor, i.e. >=22. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
95 lines
3.2 KiB
YAML
95 lines
3.2 KiB
YAML
name: "rate limit"
|
||
|
||
# any branch is useful for testing before a PR is submitted
|
||
on:
|
||
push:
|
||
paths-ignore:
|
||
- "doc/**"
|
||
pull_request:
|
||
paths-ignore:
|
||
- "doc/**"
|
||
|
||
permissions:
|
||
contents: read
|
||
|
||
env:
|
||
PNPM_HOME: ~/.pnpm-store
|
||
|
||
jobs:
|
||
ratelimit:
|
||
# run on pushes to any branch
|
||
# run on PRs from external forks
|
||
if: |
|
||
(github.event_name != 'pull_request')
|
||
|| (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id)
|
||
name: test
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
-
|
||
name: Checkout repository
|
||
uses: actions/checkout@v6
|
||
- uses: actions/cache@v5
|
||
name: Cache pnpm store
|
||
with:
|
||
path: ${{ env.PNPM_HOME }}
|
||
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
||
restore-keys: |
|
||
${{ runner.os }}-pnpm-store-
|
||
- uses: pnpm/action-setup@v6
|
||
name: Install pnpm
|
||
with:
|
||
run_install: false
|
||
- name: Use Node.js
|
||
uses: actions/setup-node@v6
|
||
with:
|
||
node-version: 24
|
||
cache: pnpm
|
||
|
||
-
|
||
name: docker network
|
||
run: docker network create --subnet=172.23.0.0/16 ep_net
|
||
-
|
||
name: build docker image
|
||
run: |
|
||
docker build -f Dockerfile -t epl-debian-slim --build-arg NODE_ENV=develop .
|
||
docker build -f src/tests/ratelimit/Dockerfile.nginx -t nginx-latest .
|
||
docker build -f src/tests/ratelimit/Dockerfile.anotherip -t anotherip .
|
||
-
|
||
name: run docker images
|
||
run: |
|
||
docker run --name etherpad-docker -p 9000:9001 --rm --network ep_net --ip 172.23.42.2 -e 'TRUST_PROXY=true' epl-debian-slim &
|
||
docker run --name nginx-docker -p 8081:80 --rm --network ep_net --ip 172.23.42.1 -d nginx-latest
|
||
docker run --rm --network ep_net --ip 172.23.42.3 --name anotherip -dt anotherip
|
||
-
|
||
name: install dependencies and create symlink for ep_etherpad-lite
|
||
run: pnpm install --frozen-lockfile
|
||
-
|
||
# The etherpad container is started in the background above; without
|
||
# this wait the test step can hit nginx before etherpad is listening
|
||
# and nginx returns 502, failing the run on a cold cache. Poll the
|
||
# nginx-proxied endpoint (which is also what the test hits) until it
|
||
# stops returning 5xx.
|
||
name: Wait for etherpad behind nginx to be ready
|
||
run: |
|
||
# ~60s budget: 30 iterations × (1s curl timeout + 1s sleep).
|
||
# Cold-start of the etherpad container is well under that.
|
||
for i in $(seq 1 30); do
|
||
if curl -fsS -o /dev/null --max-time 1 http://127.0.0.1:8081/; then
|
||
echo "etherpad is ready behind nginx"
|
||
exit 0
|
||
fi
|
||
sleep 1
|
||
done
|
||
echo "ERROR: etherpad behind nginx did not become ready in time"
|
||
echo "--- docker ps ---"
|
||
docker ps -a || true
|
||
echo "--- nginx-docker logs ---"
|
||
docker logs nginx-docker || true
|
||
echo "--- etherpad-docker logs ---"
|
||
docker logs etherpad-docker || true
|
||
exit 1
|
||
-
|
||
name: run rate limit test
|
||
run: |
|
||
cd src/tests/ratelimit
|
||
./testlimits.sh
|