mirror of
https://github.com/ether/etherpad-lite.git
synced 2026-07-17 16:47:05 +00:00
* Roll Node.js floor back to >= 24 (Active LTS) Closes #7779. #7779 originally proposed bumping past the Node 25 stop-gap to Node 26. After re-checking the release schedule, the cleaner LTS target is actually Node 24: - Node 24 (Krypton) is currently in Active LTS, supported until ~May 2028. - Node 25 hit end-of-life on April 10 2026 — the floor merged in #7752 / #7749 / #7754 a day ago ships an already-EOL major. - Node 26 was released May 5 2026 and does not enter Active LTS until October 2026. So this PR reverts the Node 25 ratchet from those three PRs and lands on Node 24 — Etherpad's runtime floor stays on a supported LTS for the next ~2 years. Runtime / infra - `package.json` + `src/package.json`: `engines.node` `>=25.0.0` -> `>=24.0.0` - `bin/functions.sh`, `bin/installer.sh`, `bin/installer.ps1`: `REQUIRED_NODE_MAJOR` 25 -> 24 - `Dockerfile`: `node:25-alpine` -> `node:24-alpine` (both stages). Corepack-via-npm workaround is intentionally kept: it works on Node 24 (which still ships corepack) and on Node 25+ (which doesn't), so the same recipe survives the next LTS bump without churn. Comments reworded accordingly. - `snap/snapcraft.yaml`: pinned `NODE_VERSION` 25.9.0 -> 24.15.0; design notes + corepack comment adjusted - `packaging/nfpm.yaml`: `nodejs (>= 25)` -> `nodejs (>= 24)` in top-level depends + deb/rpm overrides - `packaging/bin/etherpad`: comment matches the new pin - `packaging/README.md`: build prereqs + apt install snippet point at `node_24.x`; the long-stale "engines.node floor is 20" line is fixed while we're here - `.github/workflows/*.yml`: setup-node `node-version` 25 -> 24 across every workflow; backend / frontend-admin / upgrade matrices `[25]` -> `[24]` - `.github/workflows/deb-package.yml`: `NODE_MAJOR=25` + `node_25.x` smoke-test installer -> 24 - `bin/plugins/lib/npmpublish.yml`: 25 -> 24 (template propagates to the ~80 ether/* plugins via update-plugins workflow) Docs - `README.md`: install one-liner + Requirements -> Node.js >= 24 - `doc/npm-trusted-publishing.md`: runner requirement -> Node 24 - `doc/plugins.md` / `doc/plugins.adoc`: plugin metadata example `engines.node` -> `">=24.0.0"` @types/node is left at ^25.8.0 — newer type definitions cover Node 24 runtime fine and avoid an unnecessary lockfile churn. Companion homepage one-liner change to follow on ether/ether.github.com. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(plugins): example engines.node = ">=22.0.0", not core's floor Plugin code is overwhelmingly ace-hook glue and rarely uses Node-version- specific APIs, so plugin engines.node should reflect the plugin's own requirements, not track core. Showing core's 24-floor in the example encouraged plugin authors to blindly copy a tighter pin than necessary and locked plugins out of being installable on older Etherpad/Node deployments. Use the most-recent Node LTS that has actually reached EOL (20 -> EOL April 2026) as the example floor, i.e. >=22. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
352 lines
13 KiB
YAML
352 lines
13 KiB
YAML
name: "Frontend tests"
|
|
|
|
on:
|
|
push:
|
|
paths-ignore:
|
|
- 'doc/**'
|
|
pull_request:
|
|
paths-ignore:
|
|
- 'doc/**'
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
playwright-chrome:
|
|
env:
|
|
PNPM_HOME: ~/.pnpm-store
|
|
name: Playwright Chrome
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
-
|
|
name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Cache pnpm store
|
|
with:
|
|
path: ${{ env.PNPM_HOME }}
|
|
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-pnpm-store-
|
|
- uses: actions/cache@v5
|
|
name: Cache Playwright browsers
|
|
with:
|
|
path: ~/.cache/ms-playwright
|
|
key: ${{ runner.os }}-playwright-${{ hashFiles('src/package.json', 'pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-playwright-
|
|
- uses: pnpm/action-setup@v6
|
|
name: Install pnpm
|
|
with:
|
|
run_install: false
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: 24
|
|
cache: pnpm
|
|
-
|
|
name: Install all dependencies and symlink for ep_etherpad-lite
|
|
run: pnpm install --frozen-lockfile
|
|
-
|
|
name: Create settings.json
|
|
run: cp ./src/tests/settings.json settings.json
|
|
- name: Run the frontend tests
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
pnpm run prod > /tmp/etherpad-server.log 2>&1 &
|
|
# Generous 90s budget so a slow runner (or, in the with-plugins
|
|
# variant, plugin boot) doesn't lose the race against the test
|
|
# phase. Fail loudly on timeout rather than silently falling
|
|
# through to tests against a half-started server.
|
|
# --max-time bounds each probe so a stuck server can't make a
|
|
# single curl call eat the whole 90s budget.
|
|
can_connect() { curl --max-time 3 -sSfo /dev/null http://localhost:9001/; }
|
|
for i in $(seq 1 90); do can_connect && break; sleep 1; done
|
|
if ! can_connect; then
|
|
echo "::error::Etherpad did not respond on :9001 within 90s"
|
|
echo "----- server log -----"
|
|
tail -n 200 /tmp/etherpad-server.log || true
|
|
exit 1
|
|
fi
|
|
cd src
|
|
pnpm exec playwright install chromium --with-deps
|
|
pnpm run test-ui --project=chromium
|
|
- name: Upload server log on failure
|
|
uses: actions/upload-artifact@v7
|
|
if: failure()
|
|
with:
|
|
name: server-log-chrome
|
|
path: /tmp/etherpad-server.log
|
|
retention-days: 7
|
|
- uses: actions/upload-artifact@v7
|
|
if: always()
|
|
with:
|
|
name: playwright-report-chrome
|
|
path: src/playwright-report/
|
|
retention-days: 30
|
|
playwright-firefox:
|
|
env:
|
|
PNPM_HOME: ~/.pnpm-store
|
|
name: Playwright Firefox
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Cache pnpm store
|
|
with:
|
|
path: ${{ env.PNPM_HOME }}
|
|
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-pnpm-store-
|
|
- uses: actions/cache@v5
|
|
name: Cache Playwright browsers
|
|
with:
|
|
path: ~/.cache/ms-playwright
|
|
key: ${{ runner.os }}-playwright-${{ hashFiles('src/package.json', 'pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-playwright-
|
|
- uses: pnpm/action-setup@v6
|
|
name: Install pnpm
|
|
with:
|
|
run_install: false
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: 24
|
|
cache: pnpm
|
|
- name: Install all dependencies and symlink for ep_etherpad-lite
|
|
run: pnpm install --frozen-lockfile
|
|
- name: Create settings.json
|
|
run: cp ./src/tests/settings.json settings.json
|
|
- name: Run the frontend tests
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
pnpm run prod > /tmp/etherpad-server.log 2>&1 &
|
|
# Generous 90s budget so a slow runner (or, in the with-plugins
|
|
# variant, plugin boot) doesn't lose the race against the test
|
|
# phase. Fail loudly on timeout rather than silently falling
|
|
# through to tests against a half-started server.
|
|
# --max-time bounds each probe so a stuck server can't make a
|
|
# single curl call eat the whole 90s budget.
|
|
can_connect() { curl --max-time 3 -sSfo /dev/null http://localhost:9001/; }
|
|
for i in $(seq 1 90); do can_connect && break; sleep 1; done
|
|
if ! can_connect; then
|
|
echo "::error::Etherpad did not respond on :9001 within 90s"
|
|
echo "----- server log -----"
|
|
tail -n 200 /tmp/etherpad-server.log || true
|
|
exit 1
|
|
fi
|
|
cd src
|
|
pnpm exec playwright install firefox --with-deps
|
|
pnpm run test-ui --project=firefox
|
|
- name: Upload server log on failure
|
|
uses: actions/upload-artifact@v7
|
|
if: failure()
|
|
with:
|
|
name: server-log-firefox
|
|
path: /tmp/etherpad-server.log
|
|
retention-days: 7
|
|
- uses: actions/upload-artifact@v7
|
|
if: always()
|
|
with:
|
|
name: playwright-report-firefox
|
|
path: src/playwright-report/
|
|
retention-days: 30
|
|
|
|
# Frontend tests with the same /ether plugin set that backend-tests.yml
|
|
# exercises, so a core change that breaks plugin UX is caught in PR CI
|
|
# rather than after release. Re-introduces coverage that was lost when
|
|
# the workflows were nuked & rebuilt in 2023 (commit cc80db2d3) and the
|
|
# backend equivalent was restored without the frontend half.
|
|
playwright-chrome-with-plugins:
|
|
env:
|
|
PNPM_HOME: ~/.pnpm-store
|
|
name: Playwright Chrome with plugins
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Cache pnpm store
|
|
with:
|
|
path: ${{ env.PNPM_HOME }}
|
|
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-pnpm-store-
|
|
- uses: actions/cache@v5
|
|
name: Cache Playwright browsers
|
|
with:
|
|
path: ~/.cache/ms-playwright
|
|
key: ${{ runner.os }}-playwright-${{ hashFiles('src/package.json', 'pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-playwright-
|
|
- uses: pnpm/action-setup@v6
|
|
name: Install pnpm
|
|
with:
|
|
run_install: false
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: 24
|
|
cache: pnpm
|
|
- name: Install all dependencies and symlink for ep_etherpad-lite
|
|
run: pnpm install --frozen-lockfile
|
|
- name: Install Etherpad plugins
|
|
# Same plugin set as backend-tests.yml's withpluginsLinux job,
|
|
# MINUS ep_cursortrace.
|
|
#
|
|
# ep_cursortrace's `aceEditEvent` hook fires on every keyboard
|
|
# event (handleClick, handleKeyEvent, idleWorkTimer) and sends a
|
|
# cursor-position socket message per call. Under the test
|
|
# harness's `writeToPad` bursts (insertText + Enter loops) that
|
|
# stream of socket messages saturates the editor's input
|
|
# pipeline in Firefox specifically, causing intermittent
|
|
# keystroke drops and a long tail of test flakiness.
|
|
#
|
|
# Bisected via a 4-iteration probe on this branch — see commit
|
|
# history of .github/workflows/frontend-tests.yml around the
|
|
# PR-7630 timeframe. Tracked for a follow-up fix
|
|
# (debounce / throttle in ep_cursortrace's main.js).
|
|
run: >
|
|
pnpm add -w
|
|
ep_align
|
|
ep_author_hover
|
|
ep_font_color
|
|
ep_font_size
|
|
ep_hash_auth
|
|
ep_headings2
|
|
ep_markdown
|
|
ep_readonly_guest
|
|
ep_set_title_on_pad
|
|
ep_spellcheck
|
|
ep_subscript_and_superscript
|
|
ep_table_of_contents
|
|
- name: Create settings.json
|
|
run: cp ./src/tests/settings.json settings.json
|
|
- name: Run the frontend tests
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
pnpm run prod > /tmp/etherpad-server.log 2>&1 &
|
|
# Generous 90s budget so a slow runner (or, in the with-plugins
|
|
# variant, plugin boot) doesn't lose the race against the test
|
|
# phase. Fail loudly on timeout rather than silently falling
|
|
# through to tests against a half-started server.
|
|
# --max-time bounds each probe so a stuck server can't make a
|
|
# single curl call eat the whole 90s budget.
|
|
can_connect() { curl --max-time 3 -sSfo /dev/null http://localhost:9001/; }
|
|
for i in $(seq 1 90); do can_connect && break; sleep 1; done
|
|
if ! can_connect; then
|
|
echo "::error::Etherpad did not respond on :9001 within 90s"
|
|
echo "----- server log -----"
|
|
tail -n 200 /tmp/etherpad-server.log || true
|
|
exit 1
|
|
fi
|
|
cd src
|
|
pnpm exec playwright install chromium --with-deps
|
|
WITH_PLUGINS=1 pnpm run test-ui --project=chromium
|
|
- name: Upload server log on failure
|
|
uses: actions/upload-artifact@v7
|
|
if: failure()
|
|
with:
|
|
name: server-log-chrome-with-plugins
|
|
path: /tmp/etherpad-server.log
|
|
retention-days: 7
|
|
- uses: actions/upload-artifact@v7
|
|
if: always()
|
|
with:
|
|
name: playwright-report-chrome-with-plugins
|
|
path: src/playwright-report/
|
|
retention-days: 30
|
|
|
|
playwright-firefox-with-plugins:
|
|
env:
|
|
PNPM_HOME: ~/.pnpm-store
|
|
name: Playwright Firefox with plugins
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
- uses: actions/cache@v5
|
|
name: Cache pnpm store
|
|
with:
|
|
path: ${{ env.PNPM_HOME }}
|
|
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-pnpm-store-
|
|
- uses: actions/cache@v5
|
|
name: Cache Playwright browsers
|
|
with:
|
|
path: ~/.cache/ms-playwright
|
|
key: ${{ runner.os }}-playwright-${{ hashFiles('src/package.json', 'pnpm-lock.yaml') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-playwright-
|
|
- uses: pnpm/action-setup@v6
|
|
name: Install pnpm
|
|
with:
|
|
run_install: false
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: 24
|
|
cache: pnpm
|
|
- name: Install all dependencies and symlink for ep_etherpad-lite
|
|
run: pnpm install --frozen-lockfile
|
|
- name: Install Etherpad plugins
|
|
# See sibling Playwright Chrome with plugins job for the full
|
|
# rationale on why ep_cursortrace is excluded from the test
|
|
# plugin set.
|
|
run: >
|
|
pnpm add -w
|
|
ep_align
|
|
ep_author_hover
|
|
ep_font_color
|
|
ep_font_size
|
|
ep_hash_auth
|
|
ep_headings2
|
|
ep_markdown
|
|
ep_readonly_guest
|
|
ep_set_title_on_pad
|
|
ep_spellcheck
|
|
ep_subscript_and_superscript
|
|
ep_table_of_contents
|
|
- name: Create settings.json
|
|
run: cp ./src/tests/settings.json settings.json
|
|
- name: Run the frontend tests
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
pnpm run prod > /tmp/etherpad-server.log 2>&1 &
|
|
# Generous 90s budget so a slow runner (or, in the with-plugins
|
|
# variant, plugin boot) doesn't lose the race against the test
|
|
# phase. Fail loudly on timeout rather than silently falling
|
|
# through to tests against a half-started server.
|
|
# --max-time bounds each probe so a stuck server can't make a
|
|
# single curl call eat the whole 90s budget.
|
|
can_connect() { curl --max-time 3 -sSfo /dev/null http://localhost:9001/; }
|
|
for i in $(seq 1 90); do can_connect && break; sleep 1; done
|
|
if ! can_connect; then
|
|
echo "::error::Etherpad did not respond on :9001 within 90s"
|
|
echo "----- server log -----"
|
|
tail -n 200 /tmp/etherpad-server.log || true
|
|
exit 1
|
|
fi
|
|
cd src
|
|
pnpm exec playwright install firefox --with-deps
|
|
WITH_PLUGINS=1 pnpm run test-ui --project=firefox
|
|
- name: Upload server log on failure
|
|
uses: actions/upload-artifact@v7
|
|
if: failure()
|
|
with:
|
|
name: server-log-firefox-with-plugins
|
|
path: /tmp/etherpad-server.log
|
|
retention-days: 7
|
|
- uses: actions/upload-artifact@v7
|
|
if: always()
|
|
with:
|
|
name: playwright-report-firefox-with-plugins
|
|
path: src/playwright-report/
|
|
retention-days: 30
|