mirror of
https://github.com/ether/etherpad-lite.git
synced 2026-07-20 01:55:51 +00:00
chore(docker): clear most CVEs in published image (npm/pnpm/uuid + drop curl) (#7674)
* chore(docker): clear most CVEs in published image — npm/pnpm/uuid + drop curl Cuts published-image vulnerabilities from 18 (4H/13M/1L) across 8 packages to 12 (2H/9M/1L) across 3 packages. The remaining three (curl/libcurl, git, busybox) are all upstream Alpine 3.23 packages with "not fixed" status — libcurl is pulled in transitively by git and cannot be removed independently. Changes: - Provision pnpm via corepack instead of `npm install -g pnpm`, then remove the bundled npm. The base image's npm@10.9.7 ships old transitives (picomatch 4.0.3 → CVE-2026-33671/33672, brace-expansion 2.0.2 → CVE-2026-33750) that we don't otherwise need at runtime; corepack handles pnpm directly without npm. Fixes 1H + 1M. - Bump PnpmVersion 10.28.2 → 10.33.2 to align with the rest of the workflow and pull in pnpm's patched bundled brace-expansion (5.0.5 vs 5.0.4). Fixes 1M. - Add `uuid@<14.0.0` → `>=14.0.0` to pnpm.overrides (GHSA-w5hq-g745-h8pq). Fixes 1M. - Drop `curl` from the runtime apk add list and switch HEALTHCHECK to wget (busybox built-in). curl was only invoked by the healthcheck and by dev/CI scripts that don't run in the container. Removes the curl CLI binary; libcurl remains as a git transitive dep, so the `apk/alpine/curl` advisories scout reports against libcurl persist but aren't reachable from any code we ship. As a side-effect this also clears nghttp2 (CVE-2026-27135) which was a curl-CLI dep. - Switch HEALTHCHECK URL from `localhost` to `127.0.0.1` — alpine/musl resolves localhost to ::1 first and Etherpad only binds IPv4. Verified locally: docker build → docker run → healthy → docker scout cves shows 12 CVEs / 3 packages. * fix(docker): refresh corepack before preparing pnpm (Qodo) Node 22's bundled corepack ships a stale signing-key list and can reject newer pnpm releases (nodejs/corepack#612), which would fail the image build at `corepack prepare`. Mirror the snap/snapcraft.yaml workaround: `npm install -g corepack@latest` before activating pnpm, in both adminbuild and build stages. npm is still removed afterwards. * docs(changelog): note docker image dropping curl/npm/npx (Qodo) Address Qodo's "backwards-incompatible change without mitigation" rule violations by documenting the removal in the 2.7.3 breaking-changes section. Operators who exec into the container can apk add curl on demand or use the busybox wget / pnpm already present. * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm * chore: pnpm --------- Co-authored-by: SamTV12345 <40429738+samtv12345@users.noreply.github.com>
This commit is contained in:
parent
fb09b11ff5
commit
958590d1c8
25 changed files with 671 additions and 597 deletions
4
.github/workflows/backend-tests.yml
vendored
4
.github/workflows/backend-tests.yml
vendored
|
|
@ -43,7 +43,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
@ -100,7 +99,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
@ -169,7 +167,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
@ -221,7 +218,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
|
|||
6
.github/workflows/build-and-deploy-docs.yml
vendored
6
.github/workflows/build-and-deploy-docs.yml
vendored
|
|
@ -54,12 +54,10 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
# Pin Node so the build does not silently fall back to whatever the
|
||||
# runner image ships with. oxc-minify (a vitepress peer when
|
||||
# rolldown-vite is in use) requires Node ^20.19.0 || >=22.12.0; the
|
||||
# repo declares engines.node >=22.12.0 to match.
|
||||
# runner image ships with. vite 8 requires Node ^20.19.0 || >=22.12.0;
|
||||
# the repo declares engines.node >=22.12.0 to match.
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
with:
|
||||
|
|
|
|||
4
.github/workflows/docker.yml
vendored
4
.github/workflows/docker.yml
vendored
|
|
@ -52,8 +52,10 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
# Repo is checked out into ./etherpad, so the action can't find
|
||||
# packageManager in a root package.json.
|
||||
package_json_file: etherpad/package.json
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
with:
|
||||
|
|
|
|||
1
.github/workflows/frontend-admin-tests.yml
vendored
1
.github/workflows/frontend-admin-tests.yml
vendored
|
|
@ -38,7 +38,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
|
|||
4
.github/workflows/frontend-tests.yml
vendored
4
.github/workflows/frontend-tests.yml
vendored
|
|
@ -38,7 +38,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
@ -111,7 +110,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
@ -188,7 +186,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
@ -290,7 +287,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
|
|||
6
.github/workflows/handleRelease.yml
vendored
6
.github/workflows/handleRelease.yml
vendored
|
|
@ -38,8 +38,12 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
with:
|
||||
node-version: 22
|
||||
cache: pnpm
|
||||
- name: Install all dependencies and symlink for ep_etherpad-lite
|
||||
run: pnpm install --frozen-lockfile
|
||||
- name: Build etherpad
|
||||
|
|
|
|||
3
.github/workflows/load-test.yml
vendored
3
.github/workflows/load-test.yml
vendored
|
|
@ -35,7 +35,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
@ -74,7 +73,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
@ -138,7 +136,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
|
|||
6
.github/workflows/perform-type-check.yml
vendored
6
.github/workflows/perform-type-check.yml
vendored
|
|
@ -35,8 +35,12 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
with:
|
||||
node-version: 22
|
||||
cache: pnpm
|
||||
- name: Install all dependencies and symlink for ep_etherpad-lite
|
||||
run: pnpm install --frozen-lockfile
|
||||
- name: Perform type check
|
||||
|
|
|
|||
6
.github/workflows/rate-limit.yml
vendored
6
.github/workflows/rate-limit.yml
vendored
|
|
@ -38,8 +38,12 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
with:
|
||||
node-version: 22
|
||||
cache: pnpm
|
||||
|
||||
-
|
||||
name: docker network
|
||||
|
|
|
|||
10
.github/workflows/release.yml
vendored
10
.github/workflows/release.yml
vendored
|
|
@ -57,8 +57,16 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
# Repo is checked out into ./etherpad, so the action can't find
|
||||
# packageManager in a root package.json.
|
||||
package_json_file: etherpad/package.json
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
with:
|
||||
node-version: 22
|
||||
cache: pnpm
|
||||
cache-dependency-path: etherpad/pnpm-lock.yaml
|
||||
- name: Install dependencies ether.github.com
|
||||
run: pnpm install --frozen-lockfile
|
||||
working-directory: ether.github.com
|
||||
|
|
|
|||
1
.github/workflows/releaseEtherpad.yml
vendored
1
.github/workflows/releaseEtherpad.yml
vendored
|
|
@ -33,7 +33,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Install dependencies
|
||||
run: pnpm install --frozen-lockfile
|
||||
|
|
|
|||
1
.github/workflows/update-plugins.yml
vendored
1
.github/workflows/update-plugins.yml
vendored
|
|
@ -21,7 +21,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
|
||||
- name: Use Node.js
|
||||
|
|
|
|||
|
|
@ -45,7 +45,6 @@ jobs:
|
|||
- uses: pnpm/action-setup@v6
|
||||
name: Install pnpm
|
||||
with:
|
||||
version: 10.33.2
|
||||
run_install: false
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue