From 934ec7b960cee7ff380d77685e5db3615f57fd41 Mon Sep 17 00:00:00 2001 From: SamTV12345 <40429738+samtv12345@users.noreply.github.com> Date: Mon, 25 May 2026 12:04:30 +0200 Subject: [PATCH] test(admin): pass hook timeout as before() arg, not vi.setConfig MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit vi.setConfig({hookTimeout: N}) inside a before() callback is a no-op — vitest reads hook timeouts before the hook runs. padLoadFilter genuinely needs 120s for its setup, so pass it as the second arg. The two 60s files drop the override entirely (matches the global default already set in vitest.config.ts). --- src/tests/backend/specs/admin/adminSettingsResolved.ts | 2 -- src/tests/backend/specs/admin/adminSettingsSave.ts | 2 -- src/tests/backend/specs/admin/padLoadFilter.ts | 4 +--- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/tests/backend/specs/admin/adminSettingsResolved.ts b/src/tests/backend/specs/admin/adminSettingsResolved.ts index a4e31e1b8..c02a8574d 100644 --- a/src/tests/backend/specs/admin/adminSettingsResolved.ts +++ b/src/tests/backend/specs/admin/adminSettingsResolved.ts @@ -1,7 +1,6 @@ 'use strict'; import {strict as assert} from 'assert'; -import {vi} from 'vitest'; import setCookieParser from 'set-cookie-parser'; import * as fs from 'fs'; import * as os from 'os'; @@ -96,7 +95,6 @@ describe(__filename, () => { let skipReason: string | null = null; before(async () => { - vi.setConfig({hookTimeout: 60000}); await common.init(); // The load handler bails with logger.error + early return if the diff --git a/src/tests/backend/specs/admin/adminSettingsSave.ts b/src/tests/backend/specs/admin/adminSettingsSave.ts index 4006e0dac..f53b3ccee 100644 --- a/src/tests/backend/specs/admin/adminSettingsSave.ts +++ b/src/tests/backend/specs/admin/adminSettingsSave.ts @@ -1,7 +1,6 @@ 'use strict'; import {strict as assert} from 'assert'; -import {vi} from 'vitest'; import setCookieParser from 'set-cookie-parser'; import * as fs from 'fs'; import * as os from 'os'; @@ -109,7 +108,6 @@ describe(__filename, () => { let skipReason: string | null = null; before(async () => { - vi.setConfig({hookTimeout: 60000}); await common.init(); savedSettingsFilename = settings.settingsFilename; diff --git a/src/tests/backend/specs/admin/padLoadFilter.ts b/src/tests/backend/specs/admin/padLoadFilter.ts index 1e16d7e6c..3188bd1d6 100644 --- a/src/tests/backend/specs/admin/padLoadFilter.ts +++ b/src/tests/backend/specs/admin/padLoadFilter.ts @@ -9,7 +9,6 @@ // offset/limit slice, so `total` reflects the filtered universe. import {strict as assert} from 'assert'; -import {vi} from 'vitest'; import setCookieParser from 'set-cookie-parser'; const io = require('socket.io-client'); @@ -100,7 +99,6 @@ describe(__filename, () => { const editedPadIds: string[] = []; before(async () => { - vi.setConfig({hookTimeout: 120000}); await common.init(); savedUsers = settings.users; @@ -132,7 +130,7 @@ describe(__filename, () => { await pad.setText(`seed-${i}\n`, `m-${tag}-${i}`); editedPadIds.push(id); } - }); + }, 120000); after(async () => { if (socket) socket.disconnect();