From 16d3edea57cb2a26db1873101b65dd840005ca80 Mon Sep 17 00:00:00 2001 From: N7Remus Date: Fri, 10 Oct 2025 10:02:27 +0200 Subject: [PATCH] fix type error crash when calling metrics --- server/lib/stats/metrics/default.js | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/server/lib/stats/metrics/default.js b/server/lib/stats/metrics/default.js index 0cd63571..10567421 100644 --- a/server/lib/stats/metrics/default.js +++ b/server/lib/stats/metrics/default.js @@ -155,11 +155,14 @@ module.exports = async function(workers, rooms, peers, registry, config) continue; } const iceSelectedTuple = transportJson.iceSelectedTuple; - const proto = iceSelectedTuple.protocol; - const localAddr = await addr(iceSelectedTuple.localIp, - iceSelectedTuple.localPort); - const remoteAddr = await addr(iceSelectedTuple.remoteIp, - iceSelectedTuple.remotePort); + + if (iceSelectedTuple){ + const proto = iceSelectedTuple.protocol; + const localAddr = await addr(iceSelectedTuple.localIp, + iceSelectedTuple.localPort); + const remoteAddr = await addr(iceSelectedTuple.remoteIp, + iceSelectedTuple.remotePort); + } for (const [ producerId, producer ] of transport.appData.producers) { @@ -178,9 +181,9 @@ module.exports = async function(workers, rooms, peers, registry, config) 'display_name' : displayName, 'user_agent' : userAgent, 'transport_id' : quiet(transportId), - 'proto' : proto, - 'local_addr' : localAddr, - 'remote_addr' : remoteAddr, + 'proto' : proto || '', + 'local_addr' : localAddr || '', + 'remote_addr' : remoteAddr || '', 'id' : quiet(producerId), 'kind' : kind, 'codec' : codec, @@ -215,9 +218,9 @@ module.exports = async function(workers, rooms, peers, registry, config) 'display_name' : displayName, 'user_agent' : userAgent, 'transport_id' : quiet(transportId), - 'proto' : proto, - 'local_addr' : localAddr, - 'remote_addr' : remoteAddr, + 'proto' : proto || '', + 'local_addr' : localAddr || '', + 'remote_addr' : remoteAddr || '', 'id' : quiet(consumerId), 'kind' : kind, 'codec' : codec,