mirror of
https://github.com/checkpoint-restore/criu.git
synced 2026-07-18 09:05:10 +00:00
Fix four "unused local/global variable" alerts reported by CodeQL: - zdtm.py: drop unused assignment to print_next in the tail-printing loop at the end of grep_errors(). The return value of print_error() is not needed here since no further iterations follow. - crit-recode.py: remove duplicate pycriu.images.dumps(pb) call inside the except handler. The same call just raised the exception, so re-executing it would raise again and prevent the error message from being printed. - exhaustive/unix.py: drop unused msg variable. The recv() call is used for its blocking side effect to synchronize with the parent, the received data is not needed. - others/mounts/mounts.py: rename unused loop variable i to _ in the range(10) iteration. Assisted-by: Claude Code (claude-opus-4-6):claude-opus-4-6@default Signed-off-by: Adrian Reber <areber@redhat.com>
76 lines
1.8 KiB
Python
Executable file
76 lines
1.8 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
import pycriu
|
|
import sys
|
|
import os
|
|
import subprocess
|
|
|
|
find = subprocess.Popen(
|
|
['find', 'test/dump/', '-size', '+0', '-name', '*.img'],
|
|
stdout=subprocess.PIPE)
|
|
|
|
test_pass = True
|
|
|
|
|
|
def recode_and_check(imgf, o_img, pretty):
|
|
try:
|
|
pb = pycriu.images.loads(o_img, pretty)
|
|
except pycriu.images.MagicException as me:
|
|
print("%s magic %x error" % (imgf, me.magic))
|
|
return False
|
|
except Exception as e:
|
|
print("%s %sdecode fails: %s" % (imgf, pretty and 'pretty ' or '', e))
|
|
return False
|
|
|
|
try:
|
|
r_img = pycriu.images.dumps(pb)
|
|
except Exception as e:
|
|
print("%s %s encode fails: %s" % (imgf, pretty and 'pretty ' or '', e))
|
|
return False
|
|
|
|
if o_img != r_img:
|
|
print("%s %s recode mismatch" % (imgf, pretty and 'pretty ' or ''))
|
|
return False
|
|
|
|
return True
|
|
|
|
|
|
for imgf in find.stdout.readlines():
|
|
imgf = imgf.strip()
|
|
imgf_b = os.path.basename(imgf)
|
|
|
|
if imgf_b.startswith(b'pages-'):
|
|
continue
|
|
if imgf_b.startswith(b'iptables-'):
|
|
continue
|
|
if imgf_b.startswith(b'ip6tables-'):
|
|
continue
|
|
if imgf_b.startswith(b'nftables-'):
|
|
continue
|
|
if imgf_b.startswith(b'route-'):
|
|
continue
|
|
if imgf_b.startswith(b'route6-'):
|
|
continue
|
|
if imgf_b.startswith(b'ifaddr-'):
|
|
continue
|
|
if imgf_b.startswith(b'tmpfs-'):
|
|
continue
|
|
if imgf_b.startswith(b'netns-ct-'):
|
|
continue
|
|
if imgf_b.startswith(b'netns-exp-'):
|
|
continue
|
|
if imgf_b.startswith(b'rule-'):
|
|
continue
|
|
|
|
o_img = open(imgf.decode(), "rb").read()
|
|
if not recode_and_check(imgf, o_img, False):
|
|
test_pass = False
|
|
if not recode_and_check(imgf, o_img, True):
|
|
test_pass = False
|
|
|
|
find.wait()
|
|
|
|
if not test_pass:
|
|
print("FAIL")
|
|
sys.exit(1)
|
|
|
|
print("PASS")
|