mirror of
https://github.com/checkpoint-restore/criu.git
synced 2026-01-23 02:14:37 +00:00
36f1e9d38c
As of Alpine Linux 3.19, musl libc no longer contains separate
fopen64(), fseeko64(), or ftello64() functions. This causes building
CRIU with amdgpu plugin to fail with the following error:
amdgpu_plugin.c: In function 'parallel_restore_bo_contents':
amdgpu_plugin.c:2286:17: error: implicit declaration of function 'fseeko64'; did you mean 'fseeko'? [-Wimplicit-function-declaration]
2286 | fseeko64(bo_contents_fp, entry->read_offset + offset, SEEK_SET);
| ^~~~~~~~
| fseeko
make[2]: *** [Makefile:31: amdgpu_plugin.so] Error 1
make[1]: *** [Makefile:363: amdgpu_plugin] Error 2
To fix this, add the missing $(DEFINES) to plugin builds, and since we
always compile with _FILE_OFFSET_BITS=64, we don't need the 64 suffix.
Fixes: #2826
Suggested-by: Andrei Vagin <avagin@google.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
65 lines
1.8 KiB
Makefile
65 lines
1.8 KiB
Makefile
PLUGIN_NAME := amdgpu_plugin
|
|
PLUGIN_SOBJ := amdgpu_plugin.so
|
|
|
|
|
|
PLUGIN_INCLUDE := -iquote../../include
|
|
PLUGIN_INCLUDE += -iquote../../criu/include
|
|
PLUGIN_INCLUDE += -iquote../../criu/arch/$(ARCH)/include/
|
|
PLUGIN_INCLUDE += -iquote../../
|
|
|
|
COMPEL := ../../compel/compel-host
|
|
LIBDRM_INC := -I/usr/include/libdrm
|
|
DEPS_OK := amdgpu_plugin.so amdgpu_plugin_test
|
|
DEPS_NOK := ;
|
|
|
|
__nmk_dir ?= ../../scripts/nmk/scripts/
|
|
include $(__nmk_dir)msg.mk
|
|
|
|
PLUGIN_CFLAGS := -g -Wall -Werror -D _GNU_SOURCE -shared -nostartfiles -fPIC
|
|
PLUGIN_LDFLAGS := -lpthread -lrt -ldrm -ldrm_amdgpu
|
|
|
|
ifeq ($(CONFIG_AMDGPU),y)
|
|
all: $(DEPS_OK)
|
|
else
|
|
all: $(DEPS_NOK)
|
|
endif
|
|
|
|
criu-amdgpu.pb-c.c: criu-amdgpu.proto
|
|
protoc --proto_path=. --c_out=. criu-amdgpu.proto
|
|
|
|
amdgpu_plugin.so: amdgpu_plugin.c amdgpu_plugin_drm.c amdgpu_plugin_dmabuf.c amdgpu_plugin_topology.c amdgpu_plugin_util.c criu-amdgpu.pb-c.c amdgpu_socket_utils.c
|
|
$(CC) $(PLUGIN_CFLAGS) $(DEFINES) $(shell $(COMPEL) includes) $^ -o $@ $(PLUGIN_INCLUDE) $(PLUGIN_LDFLAGS) $(LIBDRM_INC)
|
|
|
|
amdgpu_plugin_clean:
|
|
$(call msg-clean, $@)
|
|
$(Q) $(RM) amdgpu_plugin.so criu-amdgpu.pb-c*
|
|
.PHONY: amdgpu_plugin_clean
|
|
|
|
test_topology_remap: amdgpu_plugin_topology.c tests/test_topology_remap.c
|
|
$(CC) $^ -o $@ -DCOMPILE_TESTS $(PLUGIN_INCLUDE) -I .
|
|
|
|
amdgpu_plugin_test: test_topology_remap
|
|
.PHONY: amdgpu_plugin_test
|
|
|
|
amdgpu_plugin_test_clean:
|
|
$(Q) $(RM) test_topology_remap
|
|
.PHONY: amdgpu_plugin_test_clean
|
|
|
|
clean: amdgpu_plugin_clean amdgpu_plugin_test_clean
|
|
|
|
mrproper: clean
|
|
|
|
install:
|
|
ifeq ($(CONFIG_AMDGPU),y)
|
|
$(Q) mkdir -p $(DESTDIR)$(PLUGINDIR)
|
|
$(E) " INSTALL " $(PLUGIN_NAME)
|
|
$(Q) install -m 755 $(PLUGIN_SOBJ) $(DESTDIR)$(PLUGINDIR)
|
|
endif
|
|
.PHONY: install
|
|
|
|
uninstall:
|
|
ifeq ($(CONFIG_AMDGPU),y)
|
|
$(E) " UNINSTALL" $(PLUGIN_NAME)
|
|
$(Q) $(RM) $(DESTDIR)$(PLUGINDIR)/$(PLUGIN_SOBJ)
|
|
endif
|
|
.PHONY: uninstall
|