7e9a9dc342
coverity CID 389194:
1238static int dump_one_task(struct pstree_item *item, InventoryEntry *parent_ie)
1239{
...
1245 struct cr_imgset *cr_imgset = NULL;
...
11. alloc_fn: Storage is returned from allocation function cr_task_imgset_open. [show details]
12. var_assign: Assigning: cr_imgset = storage returned from cr_task_imgset_open(vpid(item), 577).
1355 cr_imgset = cr_task_imgset_open(vpid(item), O_DUMP);
13. Condition !cr_imgset, taking false branch.
1356 if (!cr_imgset)
1357 goto err_cure;
1358
...
25. Condition opts.lazy_pages, taking false branch.
1427 if (opts.lazy_pages)
1428 ret = compel_cure_remote(parasite_ctl);
1429 else
1430 ret = compel_cure(parasite_ctl);
26. Condition ret, taking true branch.
1431 if (ret) {
1432 pr_err("Can't cure (pid: %d) from parasite\n", pid);
27. Jumping to label err.
1433 goto err;
1434 }
...
1448 close_cr_imgset(&cr_imgset);
1449 exit_code = 0;
1450err:
1451 close_pid_proc();
1452 free_mappings(&vmas);
1453 xfree(dfds);
CID 389194 (#1 of 1): Resource leak (RESOURCE_LEAK)28. leaked_storage: Variable cr_imgset going out of scope leaks the storage it points to.
1454 return exit_code;
1455
1456err_cure:
1457 close_cr_imgset(&cr_imgset);
1458err_cure_imgset:
1459 ret = compel_cure(parasite_ctl);
1460 if (ret)
1461 pr_err("Can't cure (pid: %d) from parasite\n", pid);
1462 goto err;
1463}
On compel_cure() error path we do not do close_cr_imgset() thich leads
to leaked cr_imgset, let's move corresponding close_cr_imgset below err
label. Also now we can merge remove close_cr_imgset() in err_cure label
as it goes to err label later anyway. Separate err_cure_imgset label is
not needed as close_cr_imgset() is ready for cr_imgset == NULL.
v2: remove excess close_cr_imgset() in label err_cure (@adrianreber)
Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
|
||
|---|---|---|
| .circleci | ||
| .github | ||
| compel | ||
| contrib | ||
| coredump | ||
| crit | ||
| criu | ||
| Documentation | ||
| images | ||
| include | ||
| lib | ||
| plugins/amdgpu | ||
| scripts | ||
| soccr | ||
| test | ||
| .cirrus.yml | ||
| .clang-format | ||
| .drone.yml | ||
| .gitignore | ||
| .lgtm.yml | ||
| .mailmap | ||
| .travis.yml | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| CREDITS | ||
| INSTALL.md | ||
| MAINTAINERS | ||
| MAINTAINERS_GUIDE.md | ||
| Makefile | ||
| Makefile.compel | ||
| Makefile.config | ||
| Makefile.install | ||
| Makefile.versions | ||
| README.md | ||
CRIU -- A project to implement checkpoint/restore functionality for Linux
CRIU (stands for Checkpoint and Restore in Userspace) is a utility to checkpoint/restore Linux tasks.
Using this tool, you can freeze a running application (or part of it) and checkpoint it to a hard drive as a collection of files. You can then use the files to restore and run the application from the point it was frozen at. The distinctive feature of the CRIU project is that it is mainly implemented in user space. There are some more projects doing C/R for Linux, and so far CRIU appears to be the most feature-rich and up-to-date with the kernel.
CRIU project is (almost) the never-ending story, because we have to always keep up with the Linux kernel supporting checkpoint and restore for all the features it provides. Thus we're looking for contributors of all kinds -- feedback, bug reports, testing, coding, writing, etc. Please refer to CONTRIBUTING.md if you would like to get involved.
The project started as the way to do live migration for OpenVZ Linux containers, but later grew to more sophisticated and flexible tool. It is currently used by (integrated into) OpenVZ, LXC/LXD, Docker, and other software, project gets tremendous help from the community, and its packages are included into many Linux distributions.
The project home is at http://criu.org. This wiki contains all the knowledge base for CRIU we have. Pages worth starting with are:
- Installation instructions
- A simple example of usage
- Examples of more advanced usage
- Troubleshooting can be hard, some help can be found here, here and here
Checkpoint and restore of simple loop process
Advanced features
As main usage for CRIU is live migration, there's a library for it called P.Haul. Also the project exposes two cool core features as standalone libraries. These are libcompel for parasite code injection and libsoccr for TCP connections checkpoint-restore.
Live migration
True live migration using CRIU is possible, but doing all the steps by hands might be complicated. The phaul sub-project provides a Go library that encapsulates most of the complexity. This library and the Go bindings for CRIU are stored in the go-criu repository.
Parasite code injection
In order to get state of the running process CRIU needs to make this process execute some code, that would fetch the required information. To make this happen without killing the application itself, CRIU uses the parasite code injection technique, which is also available as a standalone library called libcompel.
TCP sockets checkpoint-restore
One of the CRIU features is the ability to save and restore state of a TCP socket without breaking the connection. This functionality is considered to be useful by itself, and we have it available as the libsoccr library.
Licence
The project is licensed under GPLv2 (though files sitting in the lib/ directory are LGPLv2.1).
All files in the images/ directory are licensed under the Expat license (so-called MIT). See the images/LICENSE file.