criu/test/zdtm/lib/msg.c
Kir Kolyshkin d033577954 test_msg(): avoid recursion
In (highly unlikely) case localtime() failed, test_msg() calls
pr_perror() which is a wrapper around test_msg() so we're
calling ourselves, which can lead to infinite recursion if
localtime() keeps failing. Use fprintf() here to avoid this.

Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Acked-by: Andrew Vagin <avagin@gmail.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
2015-10-26 12:12:54 +03:00

69 lines
1.4 KiB
C

#include <stdarg.h>
#include <errno.h>
#include <unistd.h>
#include <fcntl.h>
#include <sys/stat.h>
#include <sys/user.h>
#include <string.h>
#include <linux/limits.h>
#include <sys/time.h>
#include <time.h>
#include "zdtmtst.h"
int test_log_init(const char *fname, const char *suffix)
{
char path[PATH_MAX];
int logfd;
snprintf(path, sizeof(path), "%s%s", fname, suffix);
logfd = open(path, O_WRONLY | O_EXCL | O_CREAT | O_APPEND, 0644);
if (logfd < 0) {
pr_perror("Can't open file %s", path);
return -1;
}
dup2(logfd, STDERR_FILENO);
dup2(logfd, STDOUT_FILENO);
close(logfd);
setbuf(stdout, NULL);
setbuf(stderr, NULL);
return 0;
}
int zdtm_seccomp;
void test_msg(const char *format, ...)
{
va_list arg;
int off = 0;
char buf[TEST_MSG_BUFFER_SIZE];
int __errno = errno;
struct timeval tv;
struct tm *tm;
if (zdtm_seccomp) /* seccomp allows restricted set of syscall-s */
goto skip;
gettimeofday(&tv, NULL);
tm = localtime(&tv.tv_sec);
if (tm == NULL) {
fprintf(stderr, "ERROR in %s: localtime() failed: %m\n",
__func__);
} else {
off += strftime(buf, sizeof(buf), "%H:%M:%S", tm);
}
off += sprintf(buf + off, ".%.3ld: ", tv.tv_usec / 1000);
off += sprintf(buf + off, "%5d: ", getpid());
skip:
va_start(arg, format);
off += vsnprintf(buf + off, sizeof(buf) - off, format, arg);
va_end(arg);
fprintf(stderr, "%s", buf);
errno = __errno;
}