criu/test/crit-recode.py
Adrian Reber c40d1b8b10 test/crit-recode: fix file handle leak in image read
Use 'with' statement instead of open().read() to ensure the
file handle is properly closed.

Assisted-by: Claude Code (claude-opus-4-6)
Signed-off-by: Adrian Reber <areber@redhat.com>
2026-07-07 15:02:33 +01:00

77 lines
1.8 KiB
Python
Executable file

#!/usr/bin/env python3
import pycriu
import sys
import os
import subprocess
find = subprocess.Popen(
['find', 'test/dump/', '-size', '+0', '-name', '*.img'],
stdout=subprocess.PIPE)
test_pass = True
def recode_and_check(imgf, o_img, pretty):
try:
pb = pycriu.images.loads(o_img, pretty)
except pycriu.images.MagicException as me:
print("%s magic %x error" % (imgf, me.magic))
return False
except Exception as e:
print("%s %sdecode fails: %s" % (imgf, pretty and 'pretty ' or '', e))
return False
try:
r_img = pycriu.images.dumps(pb)
except Exception as e:
print("%s %s encode fails: %s" % (imgf, pretty and 'pretty ' or '', e))
return False
if o_img != r_img:
print("%s %s recode mismatch" % (imgf, pretty and 'pretty ' or ''))
return False
return True
for imgf in find.stdout.readlines():
imgf = imgf.strip()
imgf_b = os.path.basename(imgf)
if imgf_b.startswith(b'pages-'):
continue
if imgf_b.startswith(b'iptables-'):
continue
if imgf_b.startswith(b'ip6tables-'):
continue
if imgf_b.startswith(b'nftables-'):
continue
if imgf_b.startswith(b'route-'):
continue
if imgf_b.startswith(b'route6-'):
continue
if imgf_b.startswith(b'ifaddr-'):
continue
if imgf_b.startswith(b'tmpfs-'):
continue
if imgf_b.startswith(b'netns-ct-'):
continue
if imgf_b.startswith(b'netns-exp-'):
continue
if imgf_b.startswith(b'rule-'):
continue
with open(imgf.decode(), "rb") as fh:
o_img = fh.read()
if not recode_and_check(imgf, o_img, False):
test_pass = False
if not recode_and_check(imgf, o_img, True):
test_pass = False
find.wait()
if not test_pass:
print("FAIL")
sys.exit(1)
print("PASS")