From faf07489f2d4c4eaba16dc092b325f39d89f5168 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Wed, 7 Oct 2015 02:44:23 -0700 Subject: [PATCH] check_path_remap(): fix error checks Naturally, checking strstr()+1 for NULL is useless. Reported by Coverity, CID 51594. Signed-off-by: Kir Kolyshkin Signed-off-by: Pavel Emelyanov --- files-reg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/files-reg.c b/files-reg.c index f07da31a2..59d88ca42 100644 --- a/files-reg.c +++ b/files-reg.c @@ -809,13 +809,13 @@ static int check_path_remap(struct fd_link *link, const struct fd_parms *parms, char *start, *end; /* skip "./proc/" */ - start = strstr(rpath, "/") + 1; + start = strstr(rpath, "/"); if (!start) return -1; - start = strstr(start, "/") + 1; + start = strstr(start + 1, "/"); if (!start) return -1; - pid = strtol(start, &end, 10); + pid = strtol(start + 1, &end, 10); /* if we didn't find another /, this path something * like ./proc/kmsg, which we shouldn't mess with. */