Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-08-02 06:43:00 +00:00
Code Issues Projects Releases Wiki Activity

ipc: Don't access data out of allocated slab

Browse source 
We should zeroify all data actually for security
reason but this aspect will be addressed in further
patches.

Meanwhile at least allocate enought space so pb_write
won't access data which is not allocated for us.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This commit is contained in:
Cyrill Gorcunov 2013-09-14 14:55:57 +04:00 • committed by Pavel Emelyanov
parent 31050001ac
commit df4e243ea0
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ipc_ns.c
View file

@ -75,7 +75,7 @@ static int dump_ipc_sem_set(int fd, const IpcSemEntry *sem)
u16 *values;
size = sizeof(u16) * sem->nsems;
values = xmalloc(size);
values = xmalloc(round_up(size, sizeof(u64)));
if (values == NULL) {
pr_err("Failed to allocate memory for semaphore set values\n");
ret = -ENOMEM;
@ -185,7 +185,7 @@ static int dump_ipc_msg_queue_messages(int fd, const IpcMsgEntry *msq,
}
msgmax += sizeof(struct msgbuf);
message = xmalloc(msgmax);
message = xmalloc(round_up(msgmax, sizeof(u64)));
if (message == NULL) {
pr_err("Failed to allocate memory for IPC message\n");
return -ENOMEM;
@ -471,11 +471,11 @@ void ipc_sem_handler(int fd, void *obj)
int size;
pr_msg("\n");
size = sizeof(u16) * e->nsems;
size = round_up(sizeof(u16) * e->nsems, sizeof(u64));
values = xmalloc(size);
if (values == NULL)
return;
if (read_img_buf(fd, values, round_up(size, sizeof(u64))) <= 0) {
if (read_img_buf(fd, values, size) <= 0) {
xfree(values);
return;
}