Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-07-18 00:58:31 +00:00
Code Issues Projects Releases Wiki Activity

zdtm: fix incorrect open() syscall use for file creation without mode

Browse source 
We saw compilation errors like:

  error: call to ‘__open_missing_mode’ declared with attribute error:
  open with O_CREAT or O_TMPFILE in second argument needs 3 arguments

Let's fix them by adding mode 0777 everywhere.

Before this change the mode was taken randomly from stack (according to
man 2 open) and that is likely not what we want.

Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
This commit is contained in:
Pavel Tikhomirov 2026-02-26 19:11:41 +01:00 • committed by Andrei Vagin
parent f22c95d2d9
commit c180188db0
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/zdtm/static/fanotify00.c
View file

@ -223,7 +223,7 @@ int main(int argc, char *argv[])
exit(1);
}
del_after = open(fanotify_path, O_CREAT | O_TRUNC);
del_after = open(fanotify_path, O_CREAT | O_TRUNC, 0777);
if (del_after < 0) {
pr_perror("open failed");
exit(1);

8
test/zdtm/static/mountpoints.c
View file

@ -96,7 +96,7 @@ int main(int argc, char **argv)
fail("Can't mount tmpfs");
return 1;
}
tmpfs_fd = open(MPTS_ROOT "/dev/test", O_WRONLY | O_CREAT);
tmpfs_fd = open(MPTS_ROOT "/dev/test", O_WRONLY | O_CREAT, 0777);
if (write(tmpfs_fd, "hello", 5) <= 0) {
pr_perror("write() failed");
return 1;
@ -104,7 +104,7 @@ int main(int argc, char **argv)
/* Check that over-mounted files are restored on tmpfs */
mkdir(MPTS_ROOT "/dev/overmount", 0600);
fd = open(MPTS_ROOT "/dev/overmount/test.over", O_WRONLY | O_CREAT);
fd = open(MPTS_ROOT "/dev/overmount/test.over", O_WRONLY | O_CREAT, 0777);
if (fd == -1) {
pr_perror("Unable to open " MPTS_ROOT "/dev/overmount");
return -1;
@ -190,14 +190,14 @@ int main(int argc, char **argv)
}
mkdir(MPTS_ROOT "/dev/slave/test.mnt.slave/test.slave", 0600);
fd = open(MPTS_ROOT "/dev/bmfile", O_CREAT | O_WRONLY);
fd = open(MPTS_ROOT "/dev/bmfile", O_CREAT | O_WRONLY, 0777);
if (fd < 0) {
pr_perror("Can't create " MPTS_ROOT "/dev/share-1/bmfile");
return 1;
}
close(fd);
fd = open(MPTS_ROOT "/dev/bmfile-mount", O_CREAT | O_WRONLY);
fd = open(MPTS_ROOT "/dev/bmfile-mount", O_CREAT | O_WRONLY, 0777);
if (fd < 0) {
pr_perror("Can't create " MPTS_ROOT "/dev/share-1/bmfile");
return 1;