Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-01-23 10:16:41 +00:00
Code Issues Projects Releases Wiki Activity

x86: cpu -- Require compatibility on instruction level by default

Browse source 
For a long time we've been demanding from cpus to be compatible
on fpu frame level, but growing list of cpu features triggers
inability for restored programs to proceed after restore due
to specific intructions execution (such as avx2). Note the
fpu frame may carry same size but not on instruction level
where SIGILL may happen after the restore.

Thus lets require instruction mode to be set and verified by default.
Still one can drop this option via command line or rpc request.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com>
Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>
This commit is contained in:
Cyrill Gorcunov 2018-08-30 14:00:27 +03:00 • committed by Andrei Vagin
parent 51b4ca964e
commit b44eaddb29
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Documentation/criu.txt
View file

@ -322,7 +322,7 @@ For example, the command line for the above example should look like this:
- *all* for all above set.
+
By default the option is set to the combination of *fpu* and *cpu*.
By default the option is set to *fpu* and *ins*.
*--cgroup-root* ['controller':]/'newroot'::
Change the root for the controller that will be dumped. By default, *criu*

2
criu/include/cr_options.h
View file

@ -30,7 +30,7 @@
#define CPU_CAP_INS (1u << 2) /* Instructions CPU capability */
#define CPU_CAP_IMAGE (1u << 3) /* Write capability on dump and read on restore*/
#define CPU_CAP_ALL (CPU_CAP_FPU | CPU_CAP_CPU | CPU_CAP_INS)
#define CPU_CAP_DEFAULT (CPU_CAP_FPU | CPU_CAP_CPU)
#define CPU_CAP_DEFAULT (CPU_CAP_FPU | CPU_CAP_INS)
struct cg_root_opt {
struct list_head node;