Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-01-22 18:05:10 +00:00
Code Issues Projects Releases Wiki Activity

restorer.c: rm unneded struct init

Browse source 
This 'struct timespec' initialization is non needed as we call
clock_gettime() right away which is supposed to fill it in.

The real reason of removing this init is when compiled by clang
with -O0 etc (i.e. compiler flags set when GCOV=1 env var is present),
clang inserts a call to memset to initialize the structure. This,
of course, leads to "compel piegen" complaining:

	Unexpected undefined symbol: `memset'. External symbol in PIE?

One way of solving it would be to provide a memset() which will call
builtin_memset(), or a simple C implemenation. But as this is the only
place that triggers such a call to memset(), and this initialization
is not really needed, it's easier just to remove it.

Now, there might be more cases like this in the future, but for now
we are good.

Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>
This commit is contained in:
Kir Kolyshkin 2016-10-11 18:46:54 -07:00 • committed by Pavel Emelyanov
parent f18fce45a2
commit b4441d1bd8
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
criu/pie/restorer.c
View file

@ -803,7 +803,7 @@ static int timerfd_arm(struct task_restore_args *args)
pr_debug("timerfd: arm for fd %d (%d)\n", t->fd, i);
if (t->settime_flags & TFD_TIMER_ABSTIME) {
struct timespec ts = { };
struct timespec ts;
/*
* We might need to adjust value because the checkpoint