Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-07-18 00:58:31 +00:00
Code Issues Projects Releases Wiki Activity

zdtm/ipc: use snprintf and bounded writes for sysctl payloads

Browse source 
Build sysctl payloads with snprintf() and check for error/truncation before writing.

Use the returned payload length for write() instead of fixed-size writes, so only formatted bytes are written.

On snprintf failure/truncation, print an explicit error message and return -1. On write/open helper failures, return -1 because callers only use success/failure and pr_perror() already logs errno.

Signed-off-by: Farzan Aman Khan <farzanaman99@gmail.com>
This commit is contained in:
Farzan Aman Khan 2026-03-30 15:38:39 +05:30 • committed by Andrei Vagin
parent 740d67749b
commit 9afe2e92df
1 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

20
test/zdtm/static/ipc_namespace.c
View file

@ -221,8 +221,13 @@ static int rand_ipc_sysctl(char *name, unsigned int val)
pr_perror("Can't open %s", name);
return -1;
}
sprintf(buf, "%d\n", val);
ret = write(fd, buf, strlen(buf));
ret = snprintf(buf, sizeof(buf), "%u\n", val);
if (ret < 0 || ret >= sizeof(buf)) {
pr_err("Can't format %u for %s\n", val, name);
close(fd);
return -1;
}
ret = write(fd, buf, ret);
if (ret < 0) {
pr_perror("Can't write %u into %s", val, name);
close(fd);
@ -246,9 +251,14 @@ static int rand_ipc_sem(void)
pr_perror("Can't open %s", name);
return -1;
}
sprintf(buf, "%d %d %d %d\n", (unsigned)lrand48(), (unsigned)lrand48(), (unsigned)lrand48(),
(unsigned)lrand48() % MAX_MNI);
ret = write(fd, buf, 128);
ret = snprintf(buf, sizeof(buf), "%u %u %u %u\n", (unsigned)lrand48(), (unsigned)lrand48(),
(unsigned)lrand48(), (unsigned)lrand48() % MAX_MNI);
if (ret < 0 || ret >= sizeof(buf)) {
pr_err("Can't format semaphore sysctl payload for %s\n", name);
close(fd);
return -1;
}
ret = write(fd, buf, ret);
if (ret < 0) {
pr_perror("Can't write %s", name);
close(fd);