Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-07-17 16:47:50 +00:00
Code Issues Projects Releases Wiki Activity

lib, criu: remove unnecessary NULL checks before free()

Browse source 
free(NULL) is a no-op per the C standard (C99 7.20.3.2), so
guarding free() calls with NULL checks is unnecessary.

Assisted-by: Claude Code (claude-opus-4-6)
Signed-off-by: Adrian Reber <areber@redhat.com>
This commit is contained in:
Adrian Reber 2026-07-10 09:02:26 +00:00 • committed by Radostin Stoyanov
parent c4d525b695
commit 74cbf9e2e7
2 changed files with 7 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

3
criu/proc_parse.c
View file

@ -1758,8 +1758,7 @@ struct mount_info *parse_mountinfo(pid_t pid, struct ns_id *nsid, bool for_dump)
}
}
end:
if (fsname)
free(fsname);
free(fsname);
if (new)
mntinfo_add_list_before(&list, new);

18
lib/c/criu.c
View file

@ -1100,8 +1100,7 @@ int criu_local_add_irmap_path(criu_opts *opts, const char *path)
return 0;
err:
if (my_path)
free(my_path);
free(my_path);
return -ENOMEM;
}
@ -1250,8 +1249,7 @@ int criu_local_add_external(criu_opts *opts, const char *key)
opts->rpc->n_external = nr;
return 0;
err:
if (e)
free(e);
free(e);
return -ENOMEM;
}
@ -2037,14 +2035,10 @@ int criu_local_join_ns_add(criu_opts *opts, const char *ns, const char *ns_file,
return 0;
err:
if (_ns)
free(_ns);
if (_ns_file)
free(_ns_file);
if (_extra_opt)
free(_extra_opt);
if (join_ns)
free(join_ns);
free(_ns);
free(_ns_file);
free(_extra_opt);
free(join_ns);
return -1;
}