Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-01-23 02:14:37 +00:00
Code Issues Projects Releases Wiki Activity

Makefile: add .FORCE target

Browse source 
Sorry for introducing that, but we need to force-rebuild implicit
rules on the level of main Makefile. All the sub-makefiles should
decide if the force-rebuilding target really needs a rebuild,
because they know it's dependencies.

Pattern-specific rules are implicit, so something like:
.PHONY: compel/% criu/% #...
will not work.
.FORCE target seems the simplest way to solve this
"going to submake on rebuild" problem.
But maybe there is more elegant proposal?

FWIW, before this patch:
    [criu]$ make compel/compel
    make[1]: Entering directory '~/tools/criu'
      HOSTDEP  compel/handle-elf-32.d
    ...
      HOSTLINK compel/compel
    make[1]: Leaving directory '~/tools/criu'
    [criu]$ touch compel/main.c
    [criu]$ make compel/compel
    make: 'compel/compel' is up to date.
    [criu]$ touch compel/Makefile
    [criu]$ make compel/compel
    make: 'compel/compel' is up to date.
After the patch:
    [criu]$ touch compel/main.c
    [criu]$ make compel/compel
    make[1]: Entering directory '~/tools/criu'
      HOSTDEP  compel/main.d
      HOSTCC   compel/main.o
      HOSTLINK compel/compel
    make[1]: Leaving directory '~/tools/criu'
    [criu]$ touch compel/Makefile
    [criu]$ make compel/compel
    make[1]: Entering directory '~/tools/criu'
      HOSTDEP  compel/handle-elf-32.d
    ...
      HOSTLINK compel/compel
    make[1]: Leaving directory '~/tools/criu'

Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>
Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>
This commit is contained in:
Dmitry Safonov 2016-05-25 20:12:00 +03:00 • committed by Andrei Vagin
parent 80a5f519f3
commit 6f58ca5ace
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Makefile
View file

@ -202,10 +202,10 @@ $(eval $(call gen-built-in,images))
.PHONY: .FORCE
# Compel get used by CRIU, build it earlier
compel/%:
compel/%: .FORCE
$(Q) $(MAKE) $(build)=compel $@
test/compel/%:
test/compel/%: .FORCE
$(Q) $(MAKE) $(build)=compel $@
#