Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-07-21 09:10:10 +00:00
Code Issues Projects Releases Wiki Activity

cr-check: don't forget close a test socket

Browse source 
CID 996206 (#3 of 3): Resource leak (RESOURCE_LEAK)
8. leaked_handle: Handle variable "sk" going out of scope leaks the handle.

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This commit is contained in:
Andrey Vagin 2013-04-05 01:44:28 +04:00 • committed by Pavel Emelyanov
parent 4ef152447c
commit 5d244ca1bd
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
cr-check.c
View file

@ -398,7 +398,7 @@ static int check_unaligned_vmsplice(void)
static int check_so_gets(void)
{
int sk;
int sk, ret = -1;
socklen_t len;
char name[IFNAMSIZ];
@ -411,16 +411,19 @@ static int check_so_gets(void)
len = 0;
if (getsockopt(sk, SOL_SOCKET, SO_GET_FILTER, NULL, &len)) {
pr_perror("Can't get socket filter");
return -1;
goto err;
}
len = sizeof(name);
if (getsockopt(sk, SOL_SOCKET, SO_BINDTODEVICE, name, &len)) {
pr_perror("Can't get socket bound dev");
return -1;
goto err;
}
return 0;
ret = 0;
err:
close(sk);
return ret;
}
static int check_ipc(void)