Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-08-03 15:23:04 +00:00
Code Issues Projects Releases Wiki Activity

Escape using unsafe sprintf helper

Browse source 
Util it's very critical for speed we should
not use unsafe sprintf helper, we're root-granted
program and must be as safe as possible.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This commit is contained in:
Cyrill Gorcunov 2012-06-20 12:16:00 +04:00 • committed by Pavel Emelyanov
parent d25f5348ae
commit 582954685b
5 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cr-restore.c
View file

@ -711,7 +711,7 @@ static int restore_root_task(struct pstree_item *init, struct cr_options *opts)
*/
if (init->pid.pid == 1) {
sprintf(proc_mountpoint, "/tmp/crtools-proc.XXXXXX");
snprintf(proc_mountpoint, sizeof(proc_mountpoint), "/tmp/crtools-proc.XXXXXX");
if (mkdtemp(proc_mountpoint) == NULL) {
pr_err("mkdtemp failed %m");
return -1;

2
files.c
View file

@ -217,7 +217,7 @@ static int open_remap_ghost(struct reg_file_info *rfi,
if (read_img(ifd, &gfe) < 0)
return -1;
sprintf(gf->path, "%s.cr.%x.ghost", rfi->path, rfe->remap_id);
snprintf(gf->path, PATH_MAX, "%s.cr.%x.ghost", rfi->path, rfe->remap_id);
gfd = open(gf->path, O_WRONLY | O_CREAT | O_EXCL, gfe.mode);
if (gfd < 0) {
pr_perror("Can't open ghost file");

2
netfilter.c
View file

@ -34,7 +34,7 @@ static int nf_connection_switch_raw(u32 *src_addr, u16 src_port, u32 *dst_addr,
return -1;
}
sprintf(buf, nf_conn_cmd, lock ? "-A" : "-D",
snprintf(buf, sizeof(buf), nf_conn_cmd, lock ? "-A" : "-D",
dip, (int)dst_port, sip, (int)src_port);
pr_debug("\tRunning iptables [%s]\n", buf);

2
shmem.c
View file

@ -114,7 +114,7 @@ static int shmem_wait_and_open(int pid, struct shmem_info *si)
char path[128];
int ret;
sprintf(path, "/proc/%d/map_files/%lx-%lx",
snprintf(path, sizeof(path), "/proc/%d/map_files/%lx-%lx",
si->pid, si->start, si->end);
pr_info("Waiting for [%s] to appear\n", path);

2
util.c
View file

@ -268,7 +268,7 @@ inline int open_pid_proc(pid_t pid)
return fd;
}
sprintf(path, "%d", pid);
snprintf(path, sizeof(path), "%d", pid);
fd = openat(proc_dir_fd, path, O_RDONLY);
if (fd < 0)
pr_perror("Can't open %s", path);