Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-07-17 16:47:50 +00:00
Code Issues Projects Releases Wiki Activity

plugin/amdgpu: Catch error for failure to open drm device

Browse source 
kfd_criu_device_bucket.drm_fd is an unsigned int, so the comparison
device_bucket->drm_fd < 0
was always false.

Fix that, and also make the error message a bit more descriptive.

Signed-off-by: David Francis <David.Francis@amd.com>
This commit is contained in:
David Francis 2026-02-27 10:02:19 -05:00 • committed by Andrei Vagin
parent 50e22d80a5
commit 555b257c58
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
plugins/amdgpu/amdgpu_plugin.c
View file

@ -1555,7 +1555,7 @@ CR_PLUGIN_REGISTER_HOOK(CR_PLUGIN_HOOK__DUMP_EXT_FILE, amdgpu_plugin_dump_file)
static int restore_devices(struct kfd_ioctl_criu_args *args, CriuKfd *e)
{
struct kfd_criu_device_bucket *device_buckets;
int ret = 0, bucket_index = 0;
int ret = 0, bucket_index = 0, drm_fd;
pr_debug("Restoring %d devices\n", e->num_of_gpus);
args->num_devices = e->num_of_gpus;
@ -1588,12 +1588,13 @@ static int restore_devices(struct kfd_ioctl_criu_args *args, CriuKfd *e)
goto exit;
}
device_bucket->drm_fd = node_get_drm_render_device(tp_node);
if (device_bucket->drm_fd < 0) {
pr_perror("Can't pass NULL drm render fd to driver");
drm_fd = node_get_drm_render_device(tp_node);
if (drm_fd < 0) {
pr_perror("Can't open drm render fd %d\n", tp_node->drm_render_minor);
goto exit;
} else {
pr_info("passing drm render fd = %d to driver\n", device_bucket->drm_fd);
pr_info("passing drm render fd = %d to driver\n", drm_fd);
device_bucket->drm_fd = drm_fd;
}
}