Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-01-24 02:35:41 +00:00
Code Issues Projects Releases Wiki Activity

read_fd_link(): don't overrun buf

Browse source 
This is a classical off-by-one error. If sizeof(buf) is 512,
the last element is buf[511] but not buf[512].

Reported by Coverity, CID 114624, 114622 etc.

Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This commit is contained in:
Kir Kolyshkin 2015-10-07 02:44:17 -07:00 • committed by Pavel Emelyanov
parent 0570dd81d6
commit 377763e5b1
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
util.c
View file

@ -467,7 +467,7 @@ int read_fd_link(int lfd, char *buf, size_t size)
pr_err("Buffer for read link of fd %d is too small\n", lfd);
return -1;
}
buf[ret] = 0;
buf[ret - 1] = 0;
return ret;
}