From 36aedc3b114b159dd7eeaddee6ddfa138d282de5 Mon Sep 17 00:00:00 2001 From: Tycho Andersen Date: Mon, 8 Feb 2016 08:57:41 -0700 Subject: [PATCH] zdtm.py: fix checkskip logic Fix checkskip logic, also emit a clearer reason when checkskip fails as to why the test was skipped. Signed-off-by: Tycho Andersen Signed-off-by: Pavel Emelyanov --- test/zdtm.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/zdtm.py b/test/zdtm.py index 80c51c0b9..071b4540c 100755 --- a/test/zdtm.py +++ b/test/zdtm.py @@ -1078,7 +1078,7 @@ def self_checkskip(tname): chs = tname + '.checkskip' if os.access(chs, os.X_OK): ch = subprocess.Popen([chs]) - return ch.wait() == 0 and False or True + return not ch.wait() == 0 return False @@ -1159,7 +1159,7 @@ def run_tests(opts): continue if self_checkskip(t): - l.skip(t, "self") + l.skip(t, "checkskip failed") continue if opts['user']: