Mirrors/criu
1
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu.git synced 2026-08-02 14:52:19 +00:00
Code Issues Projects Releases Wiki Activity

security: Check not only real user ID

Browse source 
When dumping/restoring for unpriveledged user, check for all
sets of IDs to match, just like ptrace-may-attach in the kernel.

Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This commit is contained in:
Pavel Emelyanov 2013-09-28 16:43:25 +04:00
parent b4c8c5ae32
commit 229e4e502d
1 changed files with 8 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

25
security.c
View file

@ -22,34 +22,25 @@ void restrict_uid(unsigned int uid, unsigned int gid)
cr_gid = gid;
}
static bool check_uid(unsigned int uid)
static bool check_ids(unsigned int crid, unsigned int rid, unsigned int eid, unsigned int sid)
{
if (cr_uid == 0)
if (crid == 0)
return true;
if (cr_uid == uid)
if (crid == rid && crid == eid && crid == sid)
return true;
pr_err("UID/GID mismatch %u != (%u,%u,%u)\n", crid, rid, eid, sid);
return false;
}
bool may_dump(struct proc_status_creds *creds)
{
unsigned int uid = creds->uids[0];
if (check_uid(uid))
return true;
pr_err("UID (%u) != dumper's UID(%u)\n", uid, cr_uid);
return false;
return check_ids(cr_uid, creds->uids[0], creds->uids[1], creds->uids[2]) &&
check_ids(cr_gid, creds->gids[0], creds->gids[1], creds->gids[2]);
}
bool may_restore(CredsEntry *creds)
{
unsigned int uid = creds->uid;
if (check_uid(uid))
return true;
pr_err("UID (%u) != restorer's UID(%u)\n", uid, cr_uid);
return false;
return check_ids(cr_uid, creds->uid, creds->euid, creds->suid) &&
check_ids(cr_gid, creds->gid, creds->egid, creds->sgid);
}