From 0269883c7e73e57fa04d656cda4e6b011cfd67ef Mon Sep 17 00:00:00 2001 From: Tvrtko Ursulin Date: Wed, 15 Apr 2026 10:57:24 +0100 Subject: [PATCH] plugins/amdgpu: Use correct sizes to unmap sdma copy objects Adjusted object sizes need to be used to unmap on the cleanup path so that the unmap operations match with map for the case sizes were adjusted in the function prologue. Signed-off-by: Tvrtko Ursulin --- v2: * Improve commit message and use adjusted size in error logs too. --- plugins/amdgpu/amdgpu_plugin.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/plugins/amdgpu/amdgpu_plugin.c b/plugins/amdgpu/amdgpu_plugin.c index f00d83769..e5cbff42e 100644 --- a/plugins/amdgpu/amdgpu_plugin.c +++ b/plugins/amdgpu/amdgpu_plugin.c @@ -769,9 +769,10 @@ err_ctx: err_bo_list: free_and_unmap(packets_per_buffer * 28, h_bo_ib, h_va_ib, gpu_addr_ib, ib); err_ib_gpu_alloc: - err = amdgpu_bo_va_op(h_bo_dst, 0, size, gpu_addr_dst, 0, AMDGPU_VA_OP_UNMAP); + err = amdgpu_bo_va_op(h_bo_dst, 0, dst_bo_size, gpu_addr_dst, 0, AMDGPU_VA_OP_UNMAP); if (err) - pr_perror("failed to GPU unmap the dest BO %lx, size = %lx", gpu_addr_dst, size); + pr_perror("failed to GPU unmap the dest BO %lx, size = %lx", + gpu_addr_dst, dst_bo_size); err_dst_bo_map: err = amdgpu_va_range_free(h_va_dst); if (err) @@ -782,9 +783,10 @@ err_dst_va: if (err) pr_perror("dest bo free failed"); err_dst_bo_prep: - err = amdgpu_bo_va_op(h_bo_src, 0, size, gpu_addr_src, 0, AMDGPU_VA_OP_UNMAP); + err = amdgpu_bo_va_op(h_bo_src, 0, src_bo_size, gpu_addr_src, 0, AMDGPU_VA_OP_UNMAP); if (err) - pr_perror("failed to GPU unmap the src BO %lx, size = %lx", gpu_addr_src, size); + pr_perror("failed to GPU unmap the src BO %lx, size = %lx", + gpu_addr_src, src_bo_size); err_src_bo_map: err = amdgpu_va_range_free(h_va_src); if (err)