mirror of
https://github.com/coursera-dl/coursera-dl.git
synced 2026-07-17 16:35:35 +00:00
ff134d0915
Some JSON documents for some courses in Coursera's New Platform don't always have an `assetId` attribute right below a `definition` attribute. Since we convert a JSON document to a Python dictionary, we can't (unfortunately) just go ahead and access something like `element['definition']['assetId']`. Important aside: It seems, during my tests with the `graph-analytics` course that the method `_get_open_course_asset_ids` only gets called with such "defective" JSON documents, which *may* indicate that the `if` filtering in the list comprehension is always necessary and the lists returned by `_get_open_course_asset_ids` are always empty after filtering (again, at least with this course; haven't tested with others). We should investigate things better and see what kind of JSON documents get us there and, if possible, categorize the documents that Coursera spits so that we have a better idea of what they are sending us and how to behave. One (wild) idea would be to have a method for each possible type of JSON document returning the data structures that we need. Signed-off-by: Rogério Brito <rbrito@ime.usp.br> |
||
|---|---|---|
| .. | ||
| test | ||
| __init__.py | ||
| api.py | ||
| cookies.py | ||
| coursera_dl.py | ||
| credentials.py | ||
| define.py | ||
| downloaders.py | ||
| network.py | ||
| utils.py | ||