From dfaa4f805461d703d6d9e5e96fb4eb18adad291a Mon Sep 17 00:00:00 2001 From: coderaiser Date: Fri, 11 Apr 2014 09:49:43 -0400 Subject: [PATCH] refactor(menu) getItem --- lib/client/menu.js | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/lib/client/menu.js b/lib/client/menu.js index 94dd336a..6c38a27f 100644 --- a/lib/client/menu.js +++ b/lib/client/menu.js @@ -96,29 +96,28 @@ var CloudCmd, Util, DOM, CloudFunc, $; /** * get menu item */ - function getItem(pName, pCallBack) { - var lRet, - name = pName, + function getItem(name, callback) { + var ret, icon = name && name.toLowerCase(); icon = Util.removeStr(icon, ['(', ')']); icon = Util.replaceStr(icon, ' ', '-'); - lRet = { - name : pName, + ret = { + name : name, icon : icon }; - if (Util.isFunction(pCallBack)) - lRet.callback = pCallBack; + if (Util.isFunction(callback)) + ret.callback = callback; - else if (Util.isObject(pCallBack)) - if (pCallBack.name) - lRet.items = pCallBack; + else if (Util.isObject(callback)) + if (callback.name) + ret.items = callback; else - lRet.items = getAllItems(pCallBack); + ret.items = getAllItems(callback); - return lRet; + return ret; } /**