From d1af83e2587ddb62f879b5dac278f2c9fdb76ca9 Mon Sep 17 00:00:00 2001 From: coderaiser Date: Tue, 30 Apr 2019 19:44:49 +0300 Subject: [PATCH] feature(cloudcmd) avoid service worker reoload scripts in dev mode --- .webpack/js.js | 5 +++-- client/cloudcmd.js | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.webpack/js.js b/.webpack/js.js index e2e7ba23..7fd45044 100644 --- a/.webpack/js.js +++ b/.webpack/js.js @@ -15,7 +15,8 @@ const dirModules = './client/modules'; const modules = './modules'; const {env} = process; -const isDev = env.NODE_ENV === 'development'; +const {NODE_ENV} = env; +const isDev = NODE_ENV === 'development'; const rootDir = join(__dirname, '..'); const dist = resolve(rootDir, 'dist'); @@ -50,7 +51,7 @@ const rules = clean([ const plugins = [ new EnvironmentPlugin({ - NODE_ENV: 'production', + NODE_ENV, }), new ServiceWorkerWebpackPlugin({ diff --git a/client/cloudcmd.js b/client/cloudcmd.js index 32d54c4b..49a81d50 100644 --- a/client/cloudcmd.js +++ b/client/cloudcmd.js @@ -9,6 +9,8 @@ const {promisify} = require('es6-promisify'); const wraptile = require('wraptile/legacy'); const load = require('load.js'); +const isDev = process.env.NODE_ENV === 'development'; + const { registerSW, listenSW, @@ -49,6 +51,9 @@ function getPrefix(prefix) { } const onUpdateFound = wraptile(async (config) => { + if (isDev) + return; + const {DOM} = window; const prefix = getPrefix(config.prefix); const js = promisify(load.js);