From c0911f51817d673f400e6f9ae0a43915d7835dbe Mon Sep 17 00:00:00 2001 From: coderaiser Date: Fri, 31 Jan 2014 07:00:32 -0500 Subject: [PATCH] refactor(commander) getFilesStat --- lib/server/commander.js | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/lib/server/commander.js b/lib/server/commander.js index 464f89c8..463a15f0 100644 --- a/lib/server/commander.js +++ b/lib/server/commander.js @@ -72,7 +72,7 @@ stats : stats, }; - fs.stat(name, Util.call(getFilesStat, fileParams)); + fs.stat(name, getFilesStat.bind(null, fileParams)); } else fillJSON(filesData); @@ -83,24 +83,23 @@ * async getting file states * and putting it to lStats object */ - function getFilesStat(pParams) { - var lRet = checkParams(pParams); - lRet = lRet && Util.checkObjTrue(pParams.params, - ['callback', 'stats', 'name', 'count']); + function getFilesStat(params, error, stat) { + var n, keys, p = params; - if (lRet) { - var p = pParams, - c = p.params; - - c.stats[c.name] = !p.error ? p.data : { + if (!error) + p.stats[p.name] = stat; + else + p.stats[p.name] = { 'mode' : 0, 'size' : 0, 'isDirectory' : Util.retFalse }; - - if (c.count === Object.keys(c.stats).length) - Util.exec(c.callback); - } + + keys = Object.keys(p.stats); + n = keys.length; + + if (p.count === n) + Util.exec(p.callback); } /**