From ab55aada7b534b2d62c4bd89ab3609e46bab5d15 Mon Sep 17 00:00:00 2001 From: coderaiser Date: Sun, 16 Mar 2014 10:52:47 -0400 Subject: [PATCH] refactor(ischanged) [{name, time}] -> {name: time } --- lib/server/ischanged.js | 50 ++++++++++++++--------------------------- 1 file changed, 17 insertions(+), 33 deletions(-) diff --git a/lib/server/ischanged.js b/lib/server/ischanged.js index f59c774d..f35f1138 100644 --- a/lib/server/ischanged.js +++ b/lib/server/ischanged.js @@ -9,42 +9,26 @@ Util = main.util, time = main.time, - CHANGESNAME = JSONDIR + 'changes', - CHANGES_JSON = CHANGESNAME + '.json', + CHANGES_NAME = JSONDIR + 'changes', + CHANGES_JSON = CHANGES_NAME + '.json', + + Times = main.require(CHANGES_NAME) || {}; - Times = main.require(CHANGESNAME) || []; - exports.isFileChanged = function(name, callback) { - var readTime, data, - i, n = Times.length; - - for (i = 0; i < n; i++) { - data = Times[i]; - /* if founded row with file name - save hash */ - if (data.name === name) { - readTime = data.time; - break; - } - } + var readTime = Times[name]; time.get(name, function(error, fileTime) { - var timeChanged, data; + var json, timeChanged; - if (error) + if (error) { Util.log(error); - else if (readTime !== fileTime) { - timeChanged = true; - data = { - name: name, - time: fileTime - }; + } else if (readTime !== fileTime) { + timeChanged = true; + Times[name] = fileTime; + json = Util.stringifyJSON(Times); - if (i >= n) - Times.push(data); - else - Times[i] = data; - - writeFile(CHANGES_JSON, Util.stringifyJSON(Times)); + console.log(json); + writeFile(CHANGES_JSON, json); } Util.exec(callback, timeChanged); @@ -58,10 +42,10 @@ */ function writeFile(name, data) { fs.writeFile(name, data, function(error) { - if (error) - Util.log(error); - else - Util.log('file ' + path.basename(name) + ' written...'); + var baseName = path.basename(name), + msg = 'file ' + baseName + ' written...'; + + Util.log(error || msg); }); } })();